Add ceil_mode option for pool2d and pool3d#8651
Merged
wanghaoshuang merged 2 commits intoPaddlePaddle:developfrom Mar 6, 2018
Merged
Add ceil_mode option for pool2d and pool3d#8651wanghaoshuang merged 2 commits intoPaddlePaddle:developfrom
wanghaoshuang merged 2 commits intoPaddlePaddle:developfrom
Conversation
chengduoZH
reviewed
Feb 28, 2018
paddle/fluid/operators/pool_op.cc
Outdated
| "ceil_mode", | ||
| "(bool, default false) Wether to use the ceil function to calculate " | ||
| "output height and width." | ||
| "True is the default. If it is set to False, the floor function will" |
Contributor
There was a problem hiding this comment.
"True is the default.
==> "False is the default.
paddle/fluid/operators/pool_op.cc
Outdated
| "ceil_mode", | ||
| "(bool, default false) Wether to use the ceil function to calculate " | ||
| "output height and width." | ||
| "True is the default. If it is set to False, the floor function will" |
Contributor
There was a problem hiding this comment.
"True is the default" ==> "False is the default"
chengduoZH
approved these changes
Feb 28, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #8650