Refine cmake for cudnn op#8591
Merged
luotao1 merged 2 commits intoPaddlePaddle:developfrom Feb 27, 2018
Merged
Conversation
chengduoZH
force-pushed
the
feature/refine_cmake_for_cudnn
branch
from
e42489f to
16fc5e3
Compare
luotao1
reviewed
Feb 27, 2018
| op_library(conv_op SRCS conv_op.cc DEPS vol2col) | ||
| op_library(pool_op SRCS pool_op.cc DEPS pooling) | ||
| op_library(conv_transpose_op SRCS conv_transpose_op.cc DEPS vol2col) | ||
| endif() |
Contributor
There was a problem hiding this comment.
因为SRCS会自动补全，所以170-180行可以简化为
if (WITH_GPU)
op_library(conv_op DEPS vol2col depthwise_conv)
else()
op_library(conv_op DEPS vol2col)
op_library(pool_op DEPS pooling)
op_library(conv_transpose_op DEPS vol2col)
op_library(edit_distance_op DEPS math_function) #edit_distance_op的CPU版本原来是不是给漏了？
| op_library(pool_op SRCS pool_op.cc DEPS pooling) | ||
| op_library(conv_transpose_op SRCS conv_transpose_op.cc DEPS vol2col) | ||
| endif() | ||
|
|
Contributor
There was a problem hiding this comment.
能顺手简化下185-195行么？
op_library(fill_constant_batch_size_like_op DEPS batch_size_like)
op_library(uniform_random_batch_size_like_op DEPS batch_size_like uniform_random_op)
op_library(gaussian_random_batch_size_like_op DEPS batch_size_like gaussian_random_op)
8a3b233 to
6b312d0
Compare
luotao1
reviewed
Feb 27, 2018
Contributor
There was a problem hiding this comment.
由于math_function在16行set(op_common_deps operator op_registry math_function)中已经添加进依赖了，这儿不需要手动写，即可以删除182行。
同时可更新下169行的op_library(warpctc_op DEPS dynload_warpctc sequence_padding sequence_scale math_function)
chengduoZH
force-pushed
the
feature/refine_cmake_for_cudnn
branch
from
6b312d0 to
bfaa3f4
Compare
chengduoZH
force-pushed
the
feature/refine_cmake_for_cudnn
branch
from
bfaa3f4 to
62fe2f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #8590