Skip to content

Comments

Tensorflow benchmark#8522

Merged
gongweibao merged 27 commits intoPaddlePaddle:developfrom
gongweibao:tensorflowbenchmark
Feb 27, 2018
Merged

Tensorflow benchmark#8522
gongweibao merged 27 commits intoPaddlePaddle:developfrom
gongweibao:tensorflowbenchmark

Conversation

@gongweibao
Copy link
Contributor

No description provided.

@gongweibao gongweibao changed the title [WIP]Tensorflow benchmark Tensorflow benchmark Feb 24, 2018
print("Pass = %d, Train speed = %f imgs/s, Test accuracy = %f\n" %
(pass_id, num_samples / train_elapsed, pass_test_acc))

sv.stop()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No sv defined.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

@gongweibao gongweibao Feb 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It comes from other examples and should be cleaned up.
Done.

#FROM python:2.7.14
FROM nvidia/cuda:8.0-cudnn5-runtime-ubuntu16.04
RUN apt-get update && apt-get install -y python
FROM paddlepaddle/paddle:latest-dev
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not use this image as base image, CI built image does not enable WITH_DISTRIBUTED yet.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This not product image, it's the develop image.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, but no need, paddlepaddle/paddle:latest-dev is rather large.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.


# NOTE: By default CI built wheel packages turn WITH_DISTRIBUTE=OFF,
# so we must build one with distribute support to install in this image.
RUN pip install paddlepaddle
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whl package may need to change a lot for test, but dataset download is slow and no need to change. Use RUN pip install paddlepaddle to download dataset first.

Copy link
Contributor Author

@gongweibao gongweibao Feb 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8 # if download slowly, you can add proxy here.
9 # ENV https_proxy=

This can be confusing

The whole package may need to change a lot for test, but dataset download is slow and no need to change. Use RUN pip install paddlepaddle to download dataset first.

Do we need to add dataset from local?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also added downloading "flowers" dataset, is so large that we only want to download it once.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

value: "/workspace"
- name: PADDLE_INIT_PORT
value: "30236"
- name: PORT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should change vgg16_fluid.py to use PADDLE_INIT_PORT rather than add a new env.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Contributor

@typhoonzero typhoonzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gongweibao gongweibao merged commit ef35c4e into PaddlePaddle:develop Feb 27, 2018
@gongweibao gongweibao deleted the tensorflowbenchmark branch February 27, 2018 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants