Add SIMD flags for runtime check by gangliao · Pull Request #800 · PaddlePaddle/Paddle

gangliao · 2016-12-09T07:16:30Z

No description provided.

gangliao · 2016-12-09T07:17:26Z

paddle/utils/tests/test_SIMDFlags.cpp

+using namespace paddle; // NOLINT
+
+TEST(SIMDFlags, gccTest) {
+#if (defined(__GNUC__) || defined(__GNUG__)) && !(defined(__clang__))


GCC可以用__builtin_cpu_supports对比一下

也许我们应该找几个奇怪的CPU试一下。。不知道我们是不是AMD CPU的机器。

确实应该找其他的CPU试一下。

reyoung · 2016-12-09T07:23:08Z

paddle/utils/CpuId.h

+
+    static SIMDFlags* instance();
+
+    inline bool isSSE()       { return simd_flags_ & SIMD_SSE;   }


inline bool isSSE() const;
下同

reyoung · 2016-12-09T07:23:59Z

paddle/utils/tests/test_SIMDFlags.cpp

+using namespace paddle; // NOLINT
+
+TEST(SIMDFlags, gccTest) {
+#if (defined(__GNUC__) || defined(__GNUG__)) && !(defined(__clang__))


也许我们应该找几个奇怪的CPU试一下。。不知道我们是不是AMD CPU的机器。

reyoung · 2016-12-09T07:25:26Z

paddle/utils/CpuId.cpp

+namespace paddle {
+
+/// init simd instance
+static InitFunction __init_simd_flags(


另外，感觉起来，这里Lazy的Init也无所谓，不一定非要在main函数之前init吧。

gangliao · 2016-12-09T07:40:11Z

paddle/utils/tests/test_SIMDFlags.cpp

+#if (defined(__GNUC__) || defined(__GNUG__)) && !(defined(__clang__))
+    CHECK(__builtin_cpu_supports("sse")   == HAS_SSE);
+    CHECK(__builtin_cpu_supports("sse2")  == HAS_SSE2);
+    CHECK(__builtin_cpu_supports("sse3")  == HAS_SSE3);


这里写错了。__builtin_cpu_supports返回的值是positive number，不一定是1或者true

reyoung

LGTM

hedaoyuan · 2016-12-09T08:11:52Z

paddle/utils/CpuId.h

+
+#pragma once
+
+#include <iostream>


#include 这个用来做啥？

之前还写了个os<<重载函数，删了之后，忘了删头文件了。

hedaoyuan · 2016-12-09T08:12:39Z

paddle/utils/CpuId.h

+
+    SIMDFlags();
+
+    static SIMDFlags* instance();


instance()也可以返回const

hedaoyuan · 2016-12-09T08:18:30Z

paddle/utils/CpuId.cpp

+#ifdef _WIN32
+
+/// for MSVC
+#define CPUID(info, x)  __cpuidex(info, x, 0)


_WIN32下不需要头文件？

ok 我一起再改一下

* add argmin and arsort ops

* add argmin and argsort ops (#800) * add argmin and arsort ops * Add dot bmm ops (#803) * add bmm * add dot op * clean CreateConst * clean CreateCast * add activation ops (#808) * add activation ops * fix 1function-redefined error

* add argmin and argsort ops (PaddlePaddle#800) * add argmin and arsort ops * Add dot bmm ops (PaddlePaddle#803) * add bmm * add dot op * clean CreateConst * clean CreateCast * add activation ops (PaddlePaddle#808) * add activation ops * fix 1function-redefined error

* add argmin and arsort ops

gangliao added 2 commits December 9, 2016 13:33

Add SIMD flags for runtime check

4f73e3f

Add reference to CPUID

5c480d6

gangliao commented Dec 9, 2016

View reviewed changes

gangliao requested review from hedaoyuan and reyoung December 9, 2016 07:19

gangliao assigned wangkuiyi Dec 9, 2016

gangliao mentioned this pull request Dec 9, 2016

Check SSE/AVX/AVX2 at runtime to decline in number of release binaries #768

Closed

2 tasks

reyoung requested changes Dec 9, 2016

View reviewed changes

gangliao commented Dec 9, 2016

View reviewed changes

Fix bugs on SIMD flags and unit test

bf53427

reyoung approved these changes Dec 9, 2016

View reviewed changes

gangliao merged commit 0cdfa8c into PaddlePaddle:develop Dec 9, 2016

gangliao deleted the check_avx branch December 9, 2016 08:11

hedaoyuan reviewed Dec 9, 2016

View reviewed changes

zhhsplendid pushed a commit to zhhsplendid/Paddle that referenced this pull request Sep 25, 2019

add cosine_decay and warmup. (PaddlePaddle#800)

4d6dac6

gglin001 added a commit to graphcore/Paddle-fork that referenced this pull request Jun 20, 2022

add argmin and argsort ops (PaddlePaddle#800)

4641858

* add argmin and arsort ops

yaozhixin pushed a commit to graphcore/Paddle-fork that referenced this pull request Jul 1, 2022

add argmin and argsort ops (PaddlePaddle#800)

5088c6a

* add argmin and arsort ops

lizexu123 pushed a commit to lizexu123/Paddle that referenced this pull request Feb 23, 2024

Fix url of balzeface yaml (PaddlePaddle#800)

c785d0e

WAYKEN-TSE pushed a commit to WAYKEN-TSE/Paddle that referenced this pull request Dec 6, 2024

fix qwen2vl readme (PaddlePaddle#800)

740b81b


		static SIMDFlags* instance();

		inline bool isSSE() { return simd_flags_ & SIMD_SSE; }

Conversation

gangliao commented Dec 9, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gangliao Dec 9, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

reyoung left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

gangliao Dec 9, 2016 •

edited

Loading