Skip to content

Comments

Add distributed implementation for recommender system#7810

Merged
abhinavarora merged 2 commits intoPaddlePaddle:developfrom
abhinavarora:issue7228
Jan 25, 2018
Merged

Add distributed implementation for recommender system#7810
abhinavarora merged 2 commits intoPaddlePaddle:developfrom
abhinavarora:issue7228

Conversation

@abhinavarora
Copy link
Contributor

Fixes #7228

@abhinavarora abhinavarora self-assigned this Jan 24, 2018


def get_usr_combined_features():

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please remove these empty lines?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for pointing this out. Fixed in the latest commit.

outs = exe.run(trainer_prog,
feed=func_feed(feeding, data, place),
fetch_list=[cost])
out = np.array(outs[0])
Copy link
Contributor

@gongweibao gongweibao Jan 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we need to print some in the loop and before it exit normally.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Added new print statements in the latest commit.

Copy link
Contributor

@typhoonzero typhoonzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

@abhinavarora abhinavarora merged commit 08b736c into PaddlePaddle:develop Jan 25, 2018
@abhinavarora abhinavarora deleted the issue7228 branch January 25, 2018 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants