[Cpp API Compatibility] add all & allclose API#77542
[Cpp API Compatibility] add all & allclose API#77542Le-soleile wants to merge 31 commits intoPaddlePaddle:developfrom
Conversation
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
/re-run all-failed |
|
/re-run all-failed |
|
/re-run all-failed |
1 similar comment
|
/re-run all-failed |
| // Read the value from the tensor (could be bool, int8, int32, etc.) | ||
| auto dtype = result_tensor->dtype(); | ||
| if (dtype == phi::DataType::BOOL) { | ||
| bool* bool_ptr = result_tensor->data<bool>(); |
There was a problem hiding this comment.
确认一下paddle::experimental::allclose返回结果的tensor是什么，如果是逐个元素的比较结果，这里的处理就不对，本地做一下实验，将tensor打印出来看一下（type和data），保存好实验结果
There was a problem hiding this comment.
输出结果：
分析：
paddle::experimental::allclose()返回的是标量 Tensor（shape=[],numel=1）。- 其
dtype为paddle.bool。 - 代码中已检查了
numel != 1的情况。 - 代码能够正确从
BOOLdtype 中提取对应的值。
|
/re-run all-failed |
2 similar comments
|
/re-run all-failed |
|
/re-run all-failed |
|
/re-run all-failed |
3 similar comments
|
/re-run all-failed |
|
/re-run all-failed |
|
/re-run all-failed |
|
/re-run xpu test |
|
/re-run all-failed |
1 similar comment
|
/re-run all-failed |
|
/re-run all-failed |
| } else { | ||
| PD_THROW("allclose: unsupported result dtype"); | ||
| } | ||
| } |
There was a problem hiding this comment.
all 和 allclose 的实现是否可以放在 all.h 和 allclose.h？同时暴露 at::all 和 at::allclose？
There was a problem hiding this comment.
添加后需要像 https://github.com/PaddlePaddle/Paddle/pull/78037/changes#diff-5847905442941e26d93374313b0e119d01f39267c25427c467c7829150972c06 在 paddle/phi/api/include/compat/ATen/Functions.h 将相关函数 include 过来，以便用户使用
| at::Tensor absolute() const { return abs(); } | ||
|
|
||
| at::Tensor& absolute_() const { return abs_(); } | ||
|
|
|
/re-run all-failed |
|
/re-run all-failed |
|
/re-run all-failed |
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (72.50%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #77542 +/- ##
==========================================
Coverage ? 72.50%
==========================================
Files ? 2
Lines ? 40
Branches ? 0
==========================================
Hits ? 29
Misses ? 11
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/re-run all-failed |
4 participants
PR Category
Execute Infrastructure
PR Types
New features
Description
新增 all & allclose 兼容接口
是否引起精度变化
否