Conversation
reyoung
reviewed
Jan 22, 2018
paddle/framework/lod_tensor.h
Outdated
|
|
||
| void CopyFromCUDA(); | ||
|
|
||
| void CopyToPeer(); |
Collaborator
There was a problem hiding this comment.
There should be a flag for data has been at GPU memory, and do not copy it again.
We should overload all method of std::vector and maintain this flag.
typhoonzero
reviewed
Jan 29, 2018
Contributor
typhoonzero
left a comment
typhoonzero
left a comment
There was a problem hiding this comment.
CI failed at PyCUDATensorSetFromArray when calling set from python.
paddle/framework/lod_tensor_test.cu
Outdated
| #include "paddle/framework/lod_tensor.h" | ||
| #include "paddle/platform/assert.h" | ||
|
|
||
| #include <glog/logging.h> |
Contributor
There was a problem hiding this comment.
glog seems not used in this file.
typhoonzero
approved these changes
Jan 31, 2018
Contributor
typhoonzero
left a comment
typhoonzero
left a comment
There was a problem hiding this comment.
LGTM! Can merge this now. The file name mixed_vector.h can be renamed to other more meaningful name as we discussed offline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #7713
fix #7204
and dzhwinter/benchmark#60