[API Compatibilities] add return_type for topk
#74931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #74931 +/- ##
===========================================
Coverage ? 100.00%
===========================================
Files ? 2
Lines ? 9
Branches ? 0
===========================================
Hits ? 9
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zhwesky2010
changed the title
topktopk
SigureMo
reviewed
Aug 28, 2025
| sorted: bool = True, | ||
| name: str | None = None, | ||
| *, | ||
| out: tuple[Tensor, Tensor] | None = None, |
Contributor
Author
There was a problem hiding this comment.
- 这个out是由用户传进来的，类型可以不是Namedtuple，但输出一定是Namedtuple。
- torch的文档中也只是表明这个out参数得是
(Tensor, Tensor)，并没有更进一步的要求。
可能写out=None更好些？
Contributor
There was a problem hiding this comment.
median 同样
不是一样的，median、sort、min、max、topk这几个返回的都是两个Tensor，都像torch一样封装了返回类型。
SigureMo
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
Others
Description
add return_type for
topkand fixcompat.median's return_typecc @zhwesky2010
pcard-71500