[API Compatibilities] Add rand_like, multinomial and var #74920

LLSGYN · 2025-08-27T04:05:30Z

PR Category

User Experience

PR Types

New features

Description

添加 rand_like API
修改 multinomial 支持 out 参数
修改 var 支持 correction 和 out 参数

paddle-bot · 2025-08-27T04:05:35Z

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

zhwesky2010 · 2025-08-27T08:53:26Z

python/paddle/tensor/random.py

    seed: int = 0,
    name: str | None = None,
+    *,
+    place: PlaceLike | None = None,


这个应该不需要修改

zhwesky2010 · 2025-08-27T09:04:58Z

python/paddle/tensor/random.py

+        if not isinstance(dtype, (core.VarDesc.VarType, core.DataType)):
+            dtype = convert_np_dtype_to_dtype_(dtype)
+
+    tensor = uniform(


这个可以用paddle.rand吗，paddle.rand 也升级了，这些dtype、requires_grad都会被处理，这个API就只需要转发一下就行

可以的，预计按照这种方式进行修改：

tensor = rand(input.shape, dtype=dtype, name=name) if device is not None: tensor = tensor.to(device)

zhwesky2010 · 2025-08-27T13:44:48Z

python/paddle/tensor/random.py

+            >>> print(out4.stop_gradient)
+            False
+    """
+    if dtype is None:


你这几个参数，randn全部都有，无需再特殊处理

我们需要调用的是均匀分布的rand而不是randn，而rand并不支持这几个参数

codecov-commenter · 2025-08-27T14:20:11Z

Codecov Report

❌ Patch coverage is 92.30769% with 3 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (develop@0113151). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
python/paddle/tensor/stat.py	91.66%	2 Missing ⚠️
python/paddle/tensor/random.py	93.33%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             develop   #74920   +/-   ##
==========================================
  Coverage           ?   92.30%           
==========================================
  Files              ?        2           
  Lines              ?       39           
  Branches           ?        0           
==========================================
  Hits               ?       36           
  Misses             ?        3           
  Partials           ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

zhwesky2010 · 2025-08-28T03:49:21Z

python/paddle/tensor/random.py

+            False
+    """
+    if dtype is None:
+        dtype = input.dtype


这个无需要处理，后面的API会自行处理dtype=None的情况，取这个有点损耗

zhwesky2010 · 2025-08-28T03:55:53Z

python/paddle/tensor/random.py

+            dtype = convert_np_dtype_to_dtype_(dtype)
+
+    tensor = paddle.rand(input.shape, dtype=dtype, name=name)
+    if device is not None:


这里进行了一些额外的处理，会有一些损耗，底层kernel已经支持了place，需要利用起来。

参考paddle.randn的实现方式吧，这个实现比较标准：

https://github.com/PaddlePaddle/Paddle/pull/74849/files

这个应该就是之前我利用uniform kernel实现的思路。我先去利用它修改一下rand，然后使用rand_like转发rand来实现。

LLSGYN · 2025-08-28T15:20:30Z

参考randn_like / randn。

zhwesky2010 · 2025-08-29T03:13:04Z

python/paddle/tensor/random.py

+            False
+    """
+    if dtype is None:
+        dtype = input.dtype


只在最后一个API里处理dtype=None的情况，前面的API就直接将None往后面传，不用一直取None下的dtype。

如果其他的API不符合这个写法，做了冗余操作，帮忙一起处理下。

rand_like/randn_like必须要在前面处理dtype=None的情况，因为目标是获取和输入Tensor一致的dtype。

zhwesky2010 · 2025-08-29T03:13:33Z

python/paddle/tensor/random.py

+    *,
+    out: Tensor | None = None,
+    device: PlaceLike | None = None,
+    requires_grad: bool = False,


这个是不是还有一个pin_memory，参考下最新的rand代码

zhwesky2010 · 2025-08-29T03:15:24Z

test/legacy_test/test_creation.py

                )
                self.assertEqual(x.data_ptr(), y.data_ptr())

+    def test_rand(self):


这个新建一个文件吧，会和这个冲突

https://github.com/PaddlePaddle/Paddle/pull/74949/files

zhwesky2010

LGTM

test/legacy_test/test_variance_layer.py

+        paddle.disable_static()
+        x = paddle.to_tensor(self.x)
+        if self.use_correction:
+            out = paddle.var(


XiaoguangHu01

LGTM

zhwesky2010 added the API Compatibility label Aug 27, 2025

zhwesky2010 reviewed Aug 27, 2025

View reviewed changes

LLSGYN force-pushed the feat/out_ops1-new branch from 27ed42c to 24aaa86 Compare August 27, 2025 11:15

zhwesky2010 reviewed Aug 27, 2025

View reviewed changes

zhwesky2010 reviewed Aug 28, 2025

View reviewed changes

LLSGYN force-pushed the feat/out_ops1-new branch from 24aaa86 to 479a28e Compare August 28, 2025 14:51

zhwesky2010 reviewed Aug 29, 2025

View reviewed changes

LLSGYN added 5 commits August 29, 2025 15:31

add rand_like, multinomial and var

305a479

fix rand_like impl

d384529

update rand_like, rand, uniform implementation

ca2603e

aligning logic with rand_like

dc001bf

remove redundant operations

d42d7e5

LLSGYN force-pushed the feat/out_ops1-new branch from 7c5751c to d42d7e5 Compare August 29, 2025 07:32

zhwesky2010 approved these changes Aug 29, 2025

View reviewed changes

zhwesky2010 requested a review from SigureMo August 29, 2025 08:21

zhwesky2010 reviewed Aug 29, 2025

View reviewed changes

test/legacy_test/test_variance_layer.py

paddle.disable_static()

x = paddle.to_tensor(self.x)

if self.use_correction:

out = paddle.var(

This comment was marked as resolved.

Sign in to view

SigureMo approved these changes Aug 29, 2025

View reviewed changes

zhwesky2010 requested a review from XiaoguangHu01 August 29, 2025 10:49

XiaoguangHu01 approved these changes Aug 29, 2025

View reviewed changes

zhwesky2010 merged commit 7a6ddc9 into PaddlePaddle:develop Aug 29, 2025
98 of 101 checks passed

LLSGYN deleted the feat/out_ops1-new branch August 30, 2025 04:15

This was referenced Sep 1, 2025

[API Compatibility] Add API multinomial, var, rand_like, mean, Tensor.mean PaddlePaddle/PaConvert#674

Merged

[API compatibility] add docs for requires_grad, var, mean, multinomial, rand_like PaddlePaddle/docs#7422

Merged

[API Compatibilities] Add rand_like, multinomial and var #74920

[API Compatibilities] Add rand_like, multinomial and var #74920

Uh oh!

Conversation

LLSGYN commented Aug 27, 2025

PR Category

PR Types

Description

Uh oh!

paddle-bot bot commented Aug 27, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LLSGYN Aug 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov-commenter commented Aug 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LLSGYN commented Aug 28, 2025

Uh oh!

zhwesky2010 Aug 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zhwesky2010 left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as resolved.

Uh oh!

XiaoguangHu01 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

LLSGYN Aug 27, 2025 •

edited

Loading

codecov-commenter commented Aug 27, 2025 •

edited

Loading

zhwesky2010 Aug 29, 2025 •

edited

Loading