Skip to content

ncclSuccess support CUDA custom device #74877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2025
Merged

ncclSuccess support CUDA custom device #74877

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions paddle/phi/core/enforce.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,10 +310,10 @@ DEFINE_EXTERNAL_API_TYPE(cusolverStatus_t, CUSOLVER_STATUS_SUCCESS);
DEFINE_EXTERNAL_API_TYPE(cufftResult_t, CUFFT_SUCCESS);
DEFINE_EXTERNAL_API_TYPE(CUresult, CUDA_SUCCESS);

#if !defined(__APPLE__) && defined(PADDLE_WITH_NCCL)
#if !defined(__APPLE__) && \
(defined(PADDLE_WITH_NCCL) || defined(PADDLE_WITH_XCCL))
Copy link
Contributor

@yongqiangma yongqiangma Aug 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PADDLE_WITH_XCCL的时候打开如果是非cuda类的，会有问题吗

Copy link
Contributor Author

@YqGe585 YqGe585 Aug 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

上面还有PADDLE_WITH_CUDA的宏来控制

DEFINE_EXTERNAL_API_TYPE(ncclResult_t, ncclSuccess);
#endif

} // namespace details

template <typename T>
Expand Down
Loading