[API Compatibility] add `out` parameter for `maximum` `minimum` #74683

aquagull · 2025-08-18T03:00:39Z

PR Category

User Experience

PR Types

Others

Description

将maximum minimum下沉到C++层，并删除了相关老IR的单测

pcard-71500

paddle-bot · 2025-08-18T03:00:45Z

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

zhwesky2010 · 2025-08-18T08:11:08Z

@aquagull 冲突需要处理下

zhwesky2010

LGTM

SigureMo · 2025-08-19T12:57:40Z

python/paddle/_paddle_docs.py

+            (integer types are autocasted into float32).
+    Examples:
+        .. code-block:: python
+            >>> import paddle


如果我没记错的话，code-block 下面不加空行英文文档渲染是会出问题的

这段文档不应该直接从原来 API 文档里直接 copy 么？还会进行修改么？

这个迁移的时候从Github Files Changedcopy的，没注意到没有空行。之后会恢复

SigureMo · 2025-08-19T13:00:17Z

python/paddle/tensor/math.py

    """
    Compare two tensors and returns a new tensor containing the element-wise maxima. The equation is:
-
    .. math::


这些空行删掉之后仍然能保证英文文档能够正常渲染么？删掉的理由是什么？

zhwesky2010 · 2025-08-20T10:34:32Z

python/paddle/tensor/math.py



-def maximum(x: Tensor, y: Tensor, name: str | None = None) -> Tensor:
+@ParamAliasDecorator({"x": ["input"], "y": ["other"]})


API-bechmark没过，试试改成函数式的装饰器 param_two_alias，这个性能好一些

codecov-commenter · 2025-08-20T15:40:13Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (develop@348fa91). Learn more about missing BASE report.

Additional details and impacted files

@@             Coverage Diff             @@
##             develop    #74683   +/-   ##
===========================================
  Coverage           ?   100.00%           
===========================================
  Files              ?         2           
  Lines              ?         6           
  Branches           ?         0           
===========================================
  Hits               ?         6           
  Misses             ?         0           
  Partials           ?         0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

aquagull · 2025-08-21T02:16:12Z

/re-run all-failed

DanielSun11 · 2025-08-27T10:02:33Z

test/amp下的单测报什么错啊？删掉的原因是什么？

SigureMo · 2025-08-27T10:37:55Z

test/amp下的单测报什么错啊？删掉的原因是什么？

@DanielSun11 我当时看到另一个 PR 也简单调研了下，#74795 (comment)

这部分应该是针对老 IR 写的 AMP case，使用了 OldIrGuard，PIR AMP 写法与动态图一致，实现了动静统一，因此应该是单独的单测，这些应该确实可以删掉

这个 @wanghuancoder 可以确认下

zhwesky2010

LGTM，处理冲突

XiaoguangHu01

LGTM

aquagull · 2025-08-28T06:00:09Z

/re-run all-failed

aquagull added 2 commits August 18, 2025 10:32

update

f078f18

fix

41c53bb

zhwesky2010 added the API Compatibility label Aug 18, 2025

zhwesky2010 previously approved these changes Aug 18, 2025

View reviewed changes

aquagull closed this Aug 18, 2025

update

7569963

aquagull reopened this Aug 18, 2025

aquagull dismissed zhwesky2010’s stale review via 7569963 August 18, 2025 09:57

update

986871e

aquagull marked this pull request as draft August 19, 2025 02:29

aquagull added 2 commits August 19, 2025 11:44

update

131437b

fix

6e02cef

aquagull marked this pull request as ready for review August 19, 2025 07:44

aquagull added 3 commits August 19, 2025 16:22

fix

ed4ab4f

Merge remote-tracking branch 'paddle/develop' into api_out

95d41f3

fix docs

4c3df78

zhwesky2010 previously approved these changes Aug 19, 2025

View reviewed changes

zhwesky2010 requested a review from SigureMo August 19, 2025 12:53

SigureMo reviewed Aug 19, 2025

View reviewed changes

restore sqrt

9e3afe5

aquagull dismissed zhwesky2010’s stale review via 9e3afe5 August 20, 2025 06:35

aquagull added 2 commits August 20, 2025 14:38

fix

2c99d08

fix

b1c34e6

zhwesky2010 reviewed Aug 20, 2025

View reviewed changes

fix

9ba3741

update

a6089ef

aquagull dismissed stale reviews from SigureMo and zhwesky2010 via a6089ef August 26, 2025 03:43

aquagull and others added 5 commits August 26, 2025 16:34

update

7e00dd6

add test

e453465

fix

ef2c057

Merge branch 'develop' into api_out

5d75eae

code-style

f8c0535

aquagull changed the title ~~[API Compatibility] add out parameter for maximum minimum topk~~ [API Compatibility] add out parameter for maximum minimum Aug 26, 2025

aquagull changed the title ~~[API Compatibility] add out parameter for maximum minimum~~ [API Compatibility] add out parameter for maximum minimum topk Aug 27, 2025

aquagull added 2 commits August 27, 2025 10:22

update

81cbffb

fix

bd78b71

zhwesky2010 marked this pull request as ready for review August 27, 2025 03:29

zhwesky2010 requested a review from wanghuancoder as a code owner August 27, 2025 03:29

aquagull changed the title ~~[API Compatibility] add out parameter for maximum minimum topk~~ [API Compatibility] add out parameter for maximum minimum Aug 27, 2025

fix conflict

8005ba7

zhwesky2010 previously approved these changes Aug 27, 2025

View reviewed changes

resolve conflict

1efea68

aquagull dismissed zhwesky2010’s stale review via 1efea68 August 27, 2025 11:17

resolve conflict

eda400d

zhwesky2010 approved these changes Aug 27, 2025

View reviewed changes

aquagull requested review from SigureMo and XiaoguangHu01 August 28, 2025 03:21

SigureMo approved these changes Aug 28, 2025

View reviewed changes

XiaoguangHu01 approved these changes Aug 28, 2025

View reviewed changes

wanghuancoder merged commit 69d6153 into PaddlePaddle:develop Aug 28, 2025
72 of 73 checks passed

aquagull deleted the api_out branch September 12, 2025 03:10



		def maximum(x: Tensor, y: Tensor, name: str \| None = None) -> Tensor:
		@ParamAliasDecorator({"x": ["input"], "y": ["other"]})

[API Compatibility] add out parameter for maximum minimum #74683

[API Compatibility] add out parameter for maximum minimum #74683

Uh oh!

Conversation

aquagull commented Aug 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Category

PR Types

Description

Uh oh!

paddle-bot bot commented Aug 18, 2025

Uh oh!

zhwesky2010 commented Aug 18, 2025

Uh oh!

zhwesky2010 left a comment

Choose a reason for hiding this comment

Uh oh!

SigureMo Aug 19, 2025

Choose a reason for hiding this comment

Uh oh!

aquagull Aug 19, 2025

Choose a reason for hiding this comment

Uh oh!

SigureMo Aug 19, 2025

Choose a reason for hiding this comment

Uh oh!

aquagull Aug 19, 2025

Choose a reason for hiding this comment

Uh oh!

zhwesky2010 Aug 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aquagull Aug 20, 2025

Choose a reason for hiding this comment

Uh oh!

codecov-commenter commented Aug 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

aquagull commented Aug 21, 2025

Uh oh!

DanielSun11 commented Aug 27, 2025

Uh oh!

SigureMo commented Aug 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zhwesky2010 left a comment

Choose a reason for hiding this comment

Uh oh!

XiaoguangHu01 left a comment

Choose a reason for hiding this comment

Uh oh!

aquagull commented Aug 28, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

[API Compatibility] add `out` parameter for `maximum` `minimum` #74683

[API Compatibility] add `out` parameter for `maximum` `minimum` #74683

aquagull commented Aug 18, 2025 •

edited

Loading

zhwesky2010 Aug 20, 2025 •

edited

Loading

codecov-commenter commented Aug 20, 2025 •

edited

Loading

SigureMo commented Aug 27, 2025 •

edited

Loading