[API Compatibility] add device/dtype/bias paramters and its unit test for nn.Conv1/2/3D/nn.Embedding #74641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
zhwesky2010
reviewed
Aug 15, 2025
python/paddle/nn/layer/conv.py
Outdated
| weight_attr: ParamAttrLike | None = None, | ||
| bias_attr: ParamAttrLike | None = None, | ||
| data_format: DataLayout3D = "NCDHW", | ||
| device: str | PlaceLike | None = None, |
Contributor
There was a problem hiding this comment.
这两个位置如果插入到前面去，和torch保持位置一致，不兼容影响大吗
python/paddle/nn/functional/conv.py
Outdated
| return _C_ops.add(pre_bias, bias) | ||
| else: | ||
| return pre_bias | ||
| with ( |
Contributor
There was a problem hiding this comment.
只改变weight、bias的device，这里中间计算过程的place要改变吗
| param = param.to(device) | ||
| return param | ||
| else: | ||
| if in_pir_mode(): |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #74641 +/- ##
===========================================
Coverage ? 100.00%
===========================================
Files ? 3
Lines ? 38
Branches ? 0
===========================================
Hits ? 38
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zhiminzhang0830
changed the title
zhiminzhang0830
changed the title
zhwesky2010
reviewed
Aug 25, 2025
python/paddle/nn/layer/common.py
Outdated
| embedding_dim, | ||
| ], "Shape of weight does not match num_embeddings and embedding_dim" | ||
| self._weight_attr = ParamAttr( | ||
| initializer=paddle.nn.initializer.Assign(value=_weight), |
Contributor
There was a problem hiding this comment.
这个是不是这样可实现：
_weight.stop_gradient = _freeze
self._weight = _weight
SigureMo
reviewed
Aug 26, 2025
python/paddle/nn/layer/common.py
Outdated
| sparse: bool = False, | ||
| _weight: Tensor | None = None, | ||
| _freeze: bool = False, | ||
| device: str | PlaceLike | None = None, |
Member
There was a problem hiding this comment.
Suggested change
| device: str | PlaceLike | None = None, | |
| device: PlaceLike | None = None, |
PlaceLike 包含 str
Contributor
Author
There was a problem hiding this comment.
已修改，辛苦再review下
SigureMo
reviewed
Aug 26, 2025
python/paddle/nn/layer/conv.py
Outdated
| weight_attr: ParamAttrLike | None = None, | ||
| bias_attr: ParamAttrLike | None = None, | ||
| data_format: DataLayoutND = "NCHW", | ||
| device: str | PlaceLike | None = None, |
SigureMo
previously approved these changes
Aug 26, 2025
zhwesky2010
previously approved these changes
Aug 26, 2025
zhiminzhang0830
dismissed stale reviews from zhwesky2010 and SigureMo
via
a2837e3
Contributor
Author
|
/re-run all-failed |
Contributor
Author
|
/re-run all-failed |
SigureMo
approved these changes
Aug 27, 2025
Contributor
Author
|
/re-run all-failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
New features
Description
add device/dtype/bias paramters for nn.Conv1/2/3D, nn.Embedding
add new api: paddle.nn.Conv1/2/3d
pcard-67164