Skip to content

Conversation

@Starrysea996
Copy link
Contributor

PR Category

User Experience

PR Types

New features

Description

use put_along_axis_ to implement scatter_add_ , similar to torch.scatter_add_

@paddle-bot
Copy link

paddle-bot bot commented Aug 15, 2025

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (develop@8b5c009). Learn more about missing BASE report.

Additional details and impacted files
@@             Coverage Diff             @@
##             develop    #74632   +/-   ##
===========================================
  Coverage           ?   100.00%           
===========================================
  Files              ?         1           
  Lines              ?         2           
  Branches           ?         0           
===========================================
  Hits               ?         2           
  Misses             ?         0           
  Partials           ?         0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

zhwesky2010
zhwesky2010 previously approved these changes Aug 19, 2025
Copy link
Contributor

@zhwesky2010 zhwesky2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhwesky2010
Copy link
Contributor

@Starrysea996 冲突需要处理下

@Starrysea996
Copy link
Contributor Author

/re-run all-failed

zhwesky2010
zhwesky2010 previously approved these changes Aug 20, 2025
@zhwesky2010 zhwesky2010 requested a review from SigureMo August 20, 2025 10:26
SigureMo
SigureMo previously approved these changes Aug 20, 2025
@zhwesky2010 zhwesky2010 changed the title [API compatibility] add scatter_add inplace api [API compatibility] add scatter_add_ api Aug 20, 2025
XiaoguangHu01
XiaoguangHu01 previously approved these changes Aug 20, 2025
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Starrysea996
Copy link
Contributor Author

/re-run all-failed

kolinwei
kolinwei previously approved these changes Aug 21, 2025
luotao1
luotao1 previously approved these changes Aug 21, 2025
@Starrysea996
Copy link
Contributor Author

/re-run all-failed

2 similar comments
@Starrysea996
Copy link
Contributor Author

/re-run all-failed

@Starrysea996
Copy link
Contributor Author

/re-run all-failed

Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Starrysea996
Copy link
Contributor Author

/re-run all-failed

@zhwesky2010 zhwesky2010 merged commit ef06488 into PaddlePaddle:develop Aug 22, 2025
129 of 138 checks passed
Luckycheng222 pushed a commit to Luckycheng222/Paddle that referenced this pull request Aug 25, 2025
* add scatter_add inplace api

* change position
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants