[Accuracy diff No.167] Fix accuracy (output type) diff for paddle.cumsum API #74625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #74625 +/- ##
==========================================
Coverage ? 0
==========================================
Files ? 0
Lines ? 0
Branches ? 0
==========================================
Hits ? 0
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
/re-run all-failed |
Contributor
wanghuancoder
left a comment
wanghuancoder
left a comment
There was a problem hiding this comment.
- 如果Python端做了cast，那么unary.cc中的逻辑应该是不需要修改的
- uint16、uint32是不是也应该处理？
- 增加一个单测测试吧。
…cumsum kernel and add unit test
Contributor
Author
|
Contributor
Author
|
/re-run all-failed |
wanghuancoder
approved these changes
Aug 19, 2025
Contributor
Author
|
/re-run all-failed |
Luckycheng222
pushed a commit
to Luckycheng222/Paddle
that referenced
this pull request
Aug 25, 2025
…sum API (PaddlePaddle#74625) * fix(math.py, unary.cc): fix output type diff for cumsum kernel * fix(math.py): fix output type diff for cumsum kernel * fix(math.py): fix `cumsum` documentation * fix(cum/cum_grad.cc/cu, test_cumsum_op.py): fix output type diff for cumsum kernel and add unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Operator Mechanism
PR Types
Bug fixes
Description
Currently, the
cumsumkernel exhibits different output types between PyTorch and Paddle. For instance, when the input datatype isint8/int16/int32, PyTorch outputsint64, whereas Paddle outputs the origin datatype.This PR
pcard-67164