-
Notifications
You must be signed in to change notification settings - Fork 5.9k
[API Compatibility] Add out support for 11 APIs #74592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[API Compatibility] Add out support for 11 APIs #74592
Conversation
|
你的PR提交成功,感谢你对开源项目的贡献! |
zhwesky2010
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SigureMo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| imag (Tensor): The image component. The data type should be the same as ``real``. | ||
| name(str|None, optional): For details, please refer to :ref:`api_guide_Name`. Generally, no setting is required. Default: None. | ||
| out (Tensor|None, optional): The output tensor. Default: None. | ||
| name(str|None, optional): For details, please refer to :ref:`api_guide_Name`. Generally, no setting is required. Default: None. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
可以帮忙给这个 API 也加一下类型提示么?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
python/paddle/tensor/creation.py
Outdated
| out: paddle.Tensor | None = None, | ||
| name: str | None = None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
问一下,这些 API 里的 out 和 name 是否应该作为「仅关键字参数」呢?即 3397 行前是不是应该加一个 *?只是疑问 @zhwesky2010
fdce7a4
|
/re-run all-failed |
XiaoguangHu01
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #74592 +/- ##
==========================================
Coverage ? 90.90%
==========================================
Files ? 6
Lines ? 22
Branches ? 0
==========================================
Hits ? 20
Misses ? 2
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/re-run all-failed |
32a1211
|
/re-run all-failed |
3 similar comments
|
/re-run all-failed |
|
/re-run all-failed |
|
/re-run all-failed |
test/deprecated/prim/composite_ops/test_composite_layer_norm_grad_deprecated.py
Outdated
Show resolved
Hide resolved
test/deprecated/prim/composite_ops/test_composite_layer_norm_deprecated.py
Outdated
Show resolved
Hide resolved
test/deprecated/legacy_test/test_learning_rate_scheduler_deprecated.py
Outdated
Show resolved
Hide resolved
zhwesky2010
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
/re-run all-failed |
1 similar comment
|
/re-run all-failed |
|
/re-run xpu |
|
/re-run xpu build |
|
/re-run xpu build |
|
/re-run all-failed |
XiaoguangHu01
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
/re-run all-failed |
XiaoguangHu01
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR Category
User Experience
PR Types
New features
Description
为 11 个 API 添加 out 、参数映射、下沉 C++,并添加对应单元测试。具体清单为:
paddle.polar
paddle.stack
paddle.cos
paddle.floor
paddle.log
paddle.pow
paddle.rsqrt
paddle.sign
paddle.sin
paddle.multiply
其中,multiply 由于不在 ops.yaml 清单中,下一个 PR 中下沉至 C++。#74914
下沉到 C++ 的算子不再支持就旧静态图组网,涉及到这部分的单测直接注释。