Skip to content

Conversation

@phlrain
Copy link
Collaborator

@phlrain phlrain commented Aug 11, 2025

PR Category

Distributed Strategy

PR Types

Improvements

Description

优化dual pp 的逻辑,使得第二组send/recv 能够在attention back阶段尽早拉起
pcard-91067

@paddle-bot
Copy link

paddle-bot bot commented Aug 11, 2025

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 26.31579% with 14 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (develop@2a78ac9). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...addle/distributed/fleet/meta_parallel/dualpipev.py 7.14% 13 Missing ⚠️
...stributed/fleet/meta_parallel/zero_bubble_utils.py 80.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (26.31%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop   #74527   +/-   ##
==========================================
  Coverage           ?   26.31%           
==========================================
  Files              ?        2           
  Lines              ?       19           
  Branches           ?        0           
==========================================
  Hits               ?        5           
  Misses             ?       14           
  Partials           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phlrain phlrain merged commit 5b44422 into PaddlePaddle:develop Aug 12, 2025
55 of 58 checks passed
maxiaolong001 pushed a commit to maxiaolong001/Paddle that referenced this pull request Aug 12, 2025
* optimize dual pp overlap

* polish code

* polish code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants