[API compatibility] change gelu api for paddle#74485
Merged
zhwesky2010 merged 3 commits intoPaddlePaddle:developfrom Aug 12, 2025
Merged
[API compatibility] change gelu api for paddle#74485zhwesky2010 merged 3 commits intoPaddlePaddle:developfrom
zhwesky2010 merged 3 commits intoPaddlePaddle:developfrom
Conversation
|
你的PR提交成功，感谢你对开源项目的贡献! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #74485 +/- ##
===========================================
Coverage ? 100.00%
===========================================
Files ? 2
Lines ? 6
Branches ? 0
===========================================
Hits ? 6
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zhwesky2010
reviewed
Aug 8, 2025
| [ 0.84119201, 1.39957154]]) | ||
| """ | ||
|
|
||
| if isinstance(approximate, bool): |
Contributor
There was a problem hiding this comment.
加上
if approximate == "tanh":
approximate = True
elif approximate == "none":
approximate = False
就行
python/paddle/nn/layer/activation.py
Outdated
| ) -> None: | ||
| super().__init__() | ||
| self._approximate = approximate | ||
| self._origin_approximate = approximate |
Contributor
There was a problem hiding this comment.
这些转换不用做，直接保留 self._approximate = approximate，并透传到function里去就行，function也是支持str的
SigureMo
reviewed
Aug 11, 2025
|
|
||
| def gelu( | ||
| x: Tensor, approximate: bool = False, name: str | None = None | ||
| x: Tensor, approximate: str | bool = False, name: str | None = None |
Member
There was a problem hiding this comment.
Suggested change
| x: Tensor, approximate: str | bool = False, name: str | None = None | |
| x: Tensor, approximate: Literal["tanh", "none"] | bool = False, name: str | None = None |
SigureMo
approved these changes
Aug 11, 2025
zhwesky2010
approved these changes
Aug 12, 2025
maxiaolong001
pushed a commit
to maxiaolong001/Paddle
that referenced
this pull request
Aug 12, 2025
* change gelu api * simple gelu function and class * replace str with literal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Category
User ExperiencePR Types
New featuresDescription
Add the case where the approximate parameter is a string （“none" and "tanh") for gelu function and GELU class