-
Notifications
You must be signed in to change notification settings - Fork 5.9k
improve memory allocator #74463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve memory allocator #74463
Conversation
|
你的PR提交成功,感谢你对开源项目的贡献! |
beec9c0 to
37f7f0f
Compare
37f7f0f to
263c0ec
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #74463 +/- ##
==========================================
Coverage ? 83.76%
==========================================
Files ? 5
Lines ? 117
Branches ? 0
==========================================
Hits ? 98
Misses ? 19
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
liuruyan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
确认一下状态:AutoGrowthBestFitAllocator升级了大小池,AutoGrowthBestFitAllocatorV2暂时还没有?
| if (FLAGS_use_auto_growth_v2 || FLAGS_use_cuda_malloc_async_allocator || | ||
| FLAGS_use_virtual_memory_auto_growth) { | ||
| VLOG(6) << "PreAlloc is not implemented for " | ||
| "AutoGrowthBestFitAllocatorV2, CUDAMallocAsyncAllocator or " | ||
| "VirtualMemoryAutoGrowthBestFitAllocator."; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个if分支内是否应该添加return?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
liuruyan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
是的,v2暂时不做支持,后续梳理v2到底是否有被使用。 |
a0d23a0
PR Category
Performance OptimizationPR Types
ImprovementsDescription
improve Memory allocatorPcard-67164