[AutoParallel] fix the grad_clip logic of auto_hybrid_pp#74409
Merged
xuxinyi389 merged 5 commits intoPaddlePaddle:developfrom Aug 11, 2025
Merged
[AutoParallel] fix the grad_clip logic of auto_hybrid_pp#74409xuxinyi389 merged 5 commits intoPaddlePaddle:developfrom
xuxinyi389 merged 5 commits intoPaddlePaddle:developfrom
Conversation
|
你的PR提交成功,感谢你对开源项目的贡献! |
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (55.55%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #74409 +/- ##
==========================================
Coverage ? 55.55%
==========================================
Files ? 1
Lines ? 9
Branches ? 0
==========================================
Hits ? 5
Misses ? 4
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
/re-run all-failed |
Contributor
Author
xuxinyi389
reviewed
Aug 6, 2025
| global_norm_var.process_mesh, | ||
| global_norm_var.placements, | ||
| ) | ||
|
|
Contributor
There was a problem hiding this comment.
感觉 is_pp_enable 逻辑不够简洁,可以改成下方代码:
# Check for auto hybrid pipeline parallelism and source mesh existence
if flag_auto_hybrid_pp and src_mesh is not None:
g_mesh = dist.get_mesh()
# Check if mesh exists and pipeline parallelism is enabled ("pp" dim size > 1)
if g_mesh and "pp" in g_mesh.dim_names and g_mesh.get_dim_size("pp") > 1:
# Get the pipeline parallelism subgroup for communication
pp_group = g_mesh.get_submesh_with_dim("pp").get_group("pp")
# Perform all-reduce on the local tensor value across the PP group
global_norm_var_local = global_norm_var._local_value()
dist.all_reduce(
global_norm_var_local,
op=dist.ReduceOp.SUM,
group=pp_group,
)
# Re-shard the tensor with the reduced value
global_norm_var = dist.shard_tensor(
global_norm_var_local,
global_norm_var.process_mesh,
global_norm_var.placements,
)
Contributor
Author
|
/re-run all-failed |
Enigmatisms
pushed a commit
to Enigmatisms/Paddle
that referenced
this pull request
Aug 11, 2025
…e#74409) * fix the grad clip performance * add test * empty commit to rerun CI * modify the note * Simplify code logic
maxiaolong001
pushed a commit
to maxiaolong001/Paddle
that referenced
this pull request
Aug 12, 2025
…e#74409) * fix the grad clip performance * add test * empty commit to rerun CI * modify the note * Simplify code logic
waliwali777
added a commit
to waliwali777/Paddle2
that referenced
this pull request
Aug 26, 2025
…dlePaddle#74409)'\n This reverts commit 8f77fa2.
waliwali777
added a commit
to waliwali777/Paddle2
that referenced
this pull request
Aug 26, 2025
…dlePaddle#74409)'\n This reverts commit 8f77fa2.
waliwali777
added a commit
to waliwali777/Paddle2
that referenced
this pull request
Aug 28, 2025
…dlePaddle#74409)" This reverts commit 8f77fa2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


PR Category
Auto Parallel
PR Types
Performance
Description