Update fp8_gemm_blockwise_kernel.cu check cuda version#73581
Merged
lshpku merged 4 commits intoPaddlePaddle:developfrom Jun 27, 2025
Merged
Update fp8_gemm_blockwise_kernel.cu check cuda version#73581lshpku merged 4 commits intoPaddlePaddle:developfrom
lshpku merged 4 commits intoPaddlePaddle:developfrom
Conversation
|
你的PR提交成功，感谢你对开源项目的贡献! |
Contributor
Author
|
/re-run all-failed |
Contributor
Author
|
@risemeup1 CI已完成需要review |
lshpku
reviewed
Jun 26, 2025
| &operationDesc, CUBLAS_COMPUTE_32F, CUDA_R_32F)); | ||
|
|
||
| #if CUBLAS_VERSION >= 120804 && CUDA_VERSION >= 12060 | ||
| #if CUBLAS_VERSION >= 120901 && CUDA_VERSION >= 12090 |
Contributor
There was a problem hiding this comment.
感谢你发现这个问题！该特性是12.8.5引入的，原代码确实有疏忽，但是限制成12.9也不合适，如果你想继续合入这个PR，可以找找cublas官方文档依据，然后修改这里的版本
Contributor
Author
There was a problem hiding this comment.
使用apt-get 默认安装的12.8.4， 没有更新的版本，那安装12.8.5是怎么安装
PR这里先按12.8.5修改
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
Improvements
Description
cuda 12.8 cublas 12.8.4 没有CUBLASLT_MATMUL_MATRIX_SCALE_VEC128_32F定义，编译会有未定义错误
在 cuda 12.9 cublas 12.9.1中有，修改版本检查