send_recv variables #7161
Merged
send_recv variables #7161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typhoonzero
reviewed
Jan 3, 2018
| using namespace paddle::framework::proto; | ||
| std::istringstream iss(msg.serialized()); | ||
| switch (msg.type()) { | ||
| case sendrecv::VarType::LOD_TENSOR: { |
Contributor
There was a problem hiding this comment.
Each case can have no {}
| msg->set_serialized(oss.str()); | ||
| } | ||
|
|
||
| inline void DeserializeFromMessage(const VariableMessage &msg, |
Contributor
There was a problem hiding this comment.
Should not be inline, this function is too long.
| std::unique_ptr<SendRecvService::Stub> stub_; | ||
| }; | ||
|
|
||
| inline void SerializeToMessage(const std::string &name, |
Contributor
There was a problem hiding this comment.
Should not be inline, this function is too long.
Contributor
Author
There was a problem hiding this comment.
I think inline is a simple way, otherwise, we need a library for SerializeToMessage/DeserializeFromMessage.
paddle/operators/recv_op.cc
Outdated
| platform::DeviceContextPool::Instance(); | ||
| auto &dev_ctx = *pool.Get(dev_place); | ||
| detail::DeserializeFromMessage(v.second, dev_ctx, var); | ||
| /** |
Contributor
There was a problem hiding this comment.
Can remove commented lines.
typhoonzero
reviewed
Jan 4, 2018
Contributor
typhoonzero
left a comment
typhoonzero
left a comment
There was a problem hiding this comment.
Need unitest for dealing SelectedRows
Contributor
Author
|
@typhoonzero |
typhoonzero
reviewed
Jan 5, 2018
| add_functor(ctx, *x0, *x1, expect.get()); | ||
|
|
||
| EXPECT_EQ(actual->numel(), expect_value->numel()); | ||
|
|
Contributor
There was a problem hiding this comment.
Also should expect new return_rows().size() == rows1 + rows2
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #6959