Skip to content

move ENFORCE position #7076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 28, 2017
Merged

move ENFORCE position #7076

merged 1 commit into from
Dec 28, 2017

Conversation

@JiayiFeng
Copy link
Collaborator

@JiayiFeng JiayiFeng commented Dec 27, 2017

Move up the ENFORCE point to make sure the size of in_dims has been checked before reading it.

@JiayiFeng JiayiFeng requested a review from qingqing01 December 27, 2017 11:36
qingqing01
qingqing01 approved these changes Dec 28, 2017
View reviewed changes
Copy link
Contributor

@qingqing01 qingqing01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@JiayiFeng JiayiFeng merged commit ec8f33c into PaddlePaddle:develop Dec 28, 2017
@JiayiFeng JiayiFeng deleted the move_enfoce_position branch December 28, 2017 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qingqing01 qingqing01 qingqing01 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JiayiFeng @qingqing01