Merged
Conversation
Yancey0623
reviewed
Dec 25, 2017
Contributor
Yancey0623
left a comment
Yancey0623
left a comment
There was a problem hiding this comment.
I haven't seen the code about how to deal with SIGINT in the send side(trainer), or maybe you have any other idea?
| } | ||
|
|
||
| virtual ~RecvOp() { | ||
| void Stop() override { |
Contributor
There was a problem hiding this comment.
Maybe we also need the destructor function, and call Stop() in it.
Contributor
Author
There was a problem hiding this comment.
No. recv_op's Run may run in another thread (in unit test), Stop must be called out side dtor
Contributor
There was a problem hiding this comment.
So we also need to add the interface to pybind , maybe we coud do that in another PR.
Contributor
Author
There was a problem hiding this comment.
Yep. We can add it later when running in different clusters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #6978
fix #6893