Use for_range to rewrite adam #6967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyoung
changed the title
chengduoZH
approved these changes
Dec 25, 2017
Contributor
chengduoZH
left a comment
chengduoZH
left a comment
There was a problem hiding this comment.
I think it can be merge first, and these small questions will be modified later.
| AdamFunctor(T beta1, T beta2, T epsilon, const T* beta1_pow, | ||
| const T* beta2_pow, const T* mom1, T* mom1_out, const T* mom2, | ||
| T* mom2_out, const T* lr, const T* grad, const T* param, | ||
| T* param_out) |
Contributor
There was a problem hiding this comment.
The output variable should be the end of the function.
Collaborator
Author
There was a problem hiding this comment.
Yes. That will fit google C++ style.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6985
CPU time from
14.81s --> 12.23s, save 17%.GPU time from
0.16s --> 0.09s, save 43%