update support new device docs#6963
Merged
abhinavarora merged 3 commits intoPaddlePaddle:developfrom Dec 25, 2017
Merged
Conversation
26 tasks
abhinavarora
suggested changes
Dec 25, 2017
doc/design/support_new_device.md
Outdated
|
|
||
| #### Place | ||
| Fluid uses class [Place](https://github.com/PaddlePaddle/Paddle/blob/develop/paddle/platform/place.h#L55) to represent different devices and computing libraries. There are inheritance relationships between different kinds of `Place`. | ||
| Fluid uses class [Place](https://github.com/PaddlePaddle/Paddle/blob/develop/paddle/platform/place.h#L55) to represent the device memory where data is locating. If we add another device, we have to add corresponding `DevicePlace`. |
Contributor
There was a problem hiding this comment.
where data is locating -> where data is located
doc/design/support_new_device.md
Outdated
| ``` | ||
|
|
||
| To implementing these interfaces, we have to implement MemoryAllocator for different Devices | ||
| To implementing these interfaces, we have to implement MemoryAllocator for different Devices. |
Contributor
There was a problem hiding this comment.
implementing -> implement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #6962