Skip to content

Conversation

@dzhwinter
Copy link
Contributor

fix #6765

@dzhwinter dzhwinter changed the title "add data layout" "[WIP]add data layout" Dec 25, 2017
@dzhwinter dzhwinter changed the title "[WIP]add data layout" "add data layout" Dec 25, 2017

inline DataLayout layout() const { return layout_; }

inline void set_layout(const DataLayout layout) { layout_ = layout; }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bind this to pybind?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@typhoonzero
Copy link
Contributor

Seem CI failed on CopyTensor ops, segmentfault

Copy link
Contributor

@typhoonzero typhoonzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

@dzhwinter dzhwinter merged commit 7777c81 into PaddlePaddle:develop Dec 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

need to add a data member to represent the Layout of a Tensor

2 participants