"remove hash combine" #6932
Merged
"remove hash combine" #6932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacquesqiao
reviewed
Dec 24, 2017
| size_t operator()(const platform::Place& place) const { | ||
| int pre_hash = place.which() | ||
| << (sizeof(int) * 8 - NUM_PLACE_TYPE_LIMIT_IN_BIT); | ||
| int pre_hash = place.which() + (1 << LEFT_SHIFT); |
Member
There was a problem hiding this comment.
why not
int pre_hash = place.which() << LEFT_SHIFT;
Contributor
Author
There was a problem hiding this comment.
If we assume there will be only two kinds of Place, these two methods will be same. Otherwise, place will get an overlap with data_type.
jacquesqiao
approved these changes
Dec 24, 2017
Member
jacquesqiao
left a comment
jacquesqiao
left a comment
There was a problem hiding this comment.
merge to fix the compilation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #6933
And our CI is failed now because of removing PLACE_BIT macro in the previous PR. So this one should be merged ASAP.
Thanks!