refine OpKernelType #6879
Merged
refine OpKernelType #6879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 tasks
dzhwinter
reviewed
Dec 22, 2017
paddle/framework/op_kernel_type.h
Outdated
| int library_type = static_cast<int>(key.library_type_); | ||
|
|
||
| size_t seed = 0; | ||
| hash_combine(seed, place); |
Contributor
There was a problem hiding this comment.
how about combine these four fields as one integer, then make a hash_combine function call?
Member
Author
There was a problem hiding this comment.
We can not simply combine these four fields together. HashCombine is the function to do such work.
Contributor
There was a problem hiding this comment.
我的意思是，四次HashCombine调用开销可以省略。
KernelType种类并不多，不会发生碰撞，hash只是让分布均匀一下。
防止碰撞可以这样
constexpr int SHIFT = 8; // every kind of type less than 2^8
int data_type = static_cast<int>(key.data_type_) + 1<<(SHIFT);
int data_layout = static_cast<int>(key.data_layout_) + 1 <<(SHIFT + 1);
int library_type = static_cast<int>(key.library_type_) + 1 << (SHIFT + 2);
int kernel_id = data_type + data_layout + library_type + place.which();
std::hash<int> hasher;
return hasher(kernel_id);
paddle/framework/op_kernel_type.h
Outdated
| c-why-is-boosthash-combine-the-best-way-to-combine-hash-values | ||
| */ | ||
| template <class T> | ||
| inline void hash_combine(std::size_t& seed, const T& v) { |
jacquesqiao
reviewed
Dec 22, 2017
paddle/framework/op_kernel_type.h
Outdated
| c-why-is-boosthash-combine-the-best-way-to-combine-hash-values | ||
| */ | ||
| template <class T> | ||
| inline void HashCombine(std::size_t& seed, const T& v) { |
Member
There was a problem hiding this comment.
dzhwinter
approved these changes
Dec 24, 2017
Contributor
dzhwinter
left a comment
dzhwinter
left a comment
There was a problem hiding this comment.
This PR is a core part of our KernelKey design. We can merge it ASAP, and I will give a small fix.
@QiJune @jacquesqiao
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6769