Skip to content

add library type #6874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 22, 2017
Merged

add library type #6874

merged 1 commit into from
Dec 22, 2017

Conversation

@QiJune
Copy link
Member

@QiJune QiJune commented Dec 22, 2017

Fix #6770

@dzhwinter dzhwinter mentioned this pull request Dec 22, 2017
Closed
26 tasks
jacquesqiao
jacquesqiao approved these changes Dec 22, 2017
View reviewed changes
Copy link
Member

@jacquesqiao jacquesqiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

dzhwinter
dzhwinter approved these changes Dec 22, 2017
View reviewed changes
Copy link
Contributor

@dzhwinter dzhwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.

@QiJune QiJune merged commit ad6d6e9 into PaddlePaddle:develop Dec 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jacquesqiao jacquesqiao jacquesqiao approved these changes

@dzhwinter dzhwinter dzhwinter approved these changes

@reyoung reyoung Awaiting requested review from reyoung

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@QiJune @jacquesqiao @dzhwinter