Skip to content

Speed up ColwiseSum in CPU #6834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 21, 2017
Merged

Speed up ColwiseSum in CPU #6834

merged 2 commits into from
Dec 21, 2017

Conversation

@reyoung
Copy link
Collaborator

@reyoung reyoung commented Dec 21, 2017 •
edited
Loading

Speed up 12s -> 10s -> 1s.

Fix #6836

@reyoung reyoung requested a review from qingqing01 December 21, 2017 09:44
@reyoung reyoung changed the title Remove unnecessary reshape in ColwiseSum Speed up ColwiseSum Dec 21, 2017
@reyoung reyoung changed the title Speed up ColwiseSum Speed up ColwiseSum in CPU Dec 21, 2017
qingqing01
qingqing01 approved these changes Dec 21, 2017
View reviewed changes
Copy link
Contributor

@qingqing01 qingqing01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@reyoung reyoung merged commit 7e214b4 into PaddlePaddle:develop Dec 21, 2017
@reyoung reyoung deleted the feature/performance_tuning branch December 26, 2017 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qingqing01 qingqing01 qingqing01 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@reyoung @qingqing01