Design doc: how to support a new device/library doc#6577
Merged
abhinavarora merged 2 commits intoPaddlePaddle:developfrom Dec 13, 2017
Merged
Design doc: how to support a new device/library doc#6577abhinavarora merged 2 commits intoPaddlePaddle:developfrom
abhinavarora merged 2 commits intoPaddlePaddle:developfrom
Conversation
abhinavarora
approved these changes
Dec 13, 2017
Contributor
abhinavarora
left a comment
There was a problem hiding this comment.
LGTM!
There are some portions where the language in the documentation needs to be polished. I am approving this PR and then I can begin a new PR that polishes the language and the grammar.
Contributor
|
Very informative, thank you @QiJune ! Curious what does |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #6576