[CINN][New Hardware Update] Modify Target If-Else #64587
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
tc20042008
approved these changes
May 29, 2024
| }; | ||
| target.arch.Match( | ||
| [&](common::NVGPUArch) { | ||
| if (!FLAGS_cinn_enable_map_expr && !FLAGS_cinn_new_group_scheduler) { |
Contributor
There was a problem hiding this comment.
可以尝试提炼这些代码到单独的闭包里，比如叫NvGpuArchCompute。这样缩进更好看些。
| sch->Bind(rb_loops.back(), "threadIdx.x"); | ||
| sch->SetBuffer(rf_block, "local"); | ||
| }, | ||
| [&](std::variant<common::UnknownArch, common::X86Arch, common::ARMArch>) { |
Contributor
There was a problem hiding this comment.
在函数体里显式写注释：// Do nothing.
| bytes, | ||
| cudaMemcpyDeviceToDevice, | ||
| static_cast<cudaStream_t>(stream)); | ||
| return true; |
Contributor
There was a problem hiding this comment.
这些语义没有无脑地维持，虽然实质上差不多。
本函数的重构应该这样弄：
return input_target.arch.Match(
[&](...) {
...
return true;
}
)每个case提供一个返回值。
Contributor
Author
There was a problem hiding this comment.
可以的。不过如果原有代码只在部分case下有返回值，会难以处理。
| [&](common::X86Arch) { | ||
| std::copy(tensor->data<T>(), tensor->data<T>() + size, data.begin()); | ||
| }, | ||
| [&](std::variant<common::UnknownArch, common::ARMArch>) { |
Contributor
There was a problem hiding this comment.
【只是建议】可以不可以不用std::variant做case？总感觉那样的代码层次更少更清爽。如果觉得有些地方会导致代码冗余，我们总是可以借助lambda提炼公共代码。
Contributor
Author
There was a problem hiding this comment.
感觉可读性差不多，std::variant更强调几种case执行共性操作
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
CINN
PR Types
Improvements
Description
使用target.arch.Match替换DefaultNVGPUTarget分支。
pcard-79890