Skip to content

[SOT][dynamic shape] Implement a general match_expr for tracker #64435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SigureMo merged 11 commits into from
May 22, 2024
Merged

[SOT][dynamic shape] Implement a general match_expr for tracker #64435

SigureMo merged 11 commits into from
May 22, 2024

Conversation

@zrr1999
Copy link
Member

@zrr1999 zrr1999 commented May 19, 2024 •
edited
Loading

PR Category

Others

PR Types

Others

Description

支持 更多tracker，例如下面的情况

  • input["x"] （input={"x": 1}, input={"x": 2}）

@paddle-bot
Copy link

paddle-bot bot commented May 19, 2024

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label May 19, 2024
@zrr1999 zrr1999 changed the title Dynamic int input [SOT][dynamic shape] Implement match_expr for May 19, 2024
@zrr1999 zrr1999 changed the title [SOT][dynamic shape] Implement match_expr for [SOT][dynamic shape] Implement match_expr for all tracker May 19, 2024
SigureMo
SigureMo reviewed May 19, 2024
View reviewed changes
SigureMo
SigureMo previously approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

@SigureMo
Copy link
Member

SigureMo commented May 20, 2024

覆盖率没过，奇怪，那几行感觉应该会跑到的

@SigureMo
Copy link
Member

SigureMo commented May 21, 2024

CINN 有一个同名单测 test_dynamic_shape 被禁用了，导致我们的 test_dynamic_shape 也被禁用了，单测改个名字吧

比如叫 test_sot_dynamic_shape

SigureMo
SigureMo approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

XieYunshen
XieYunshen approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@XieYunshen XieYunshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SigureMo SigureMo self-assigned this May 22, 2024
@SigureMo SigureMo merged commit 2046686 into PaddlePaddle:develop May 22, 2024
@SigureMo SigureMo changed the title [SOT][dynamic shape] Implement match_expr for all tracker [SOT][dynamic shape] Implement a general match_expr for tracker May 22, 2024
co63oc pushed a commit to co63oc/Paddle that referenced this pull request May 23, 2024
@zrr1999 @co63oc
[SOT][dynamic shape] Implement a general match_expr for tracker (Pa…
f730f78 
…ddlePaddle#64435)
chen2016013 pushed a commit to chen2016013/Paddle that referenced this pull request May 26, 2024
@zrr1999 @chen2021673
[SOT][dynamic shape] Implement a general match_expr for tracker (Pa…
f3fb8b8 
…ddlePaddle#64435)
@zrr1999 zrr1999 mentioned this pull request Jun 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@XieYunshen XieYunshen XieYunshen approved these changes

@SigureMo SigureMo SigureMo approved these changes

@Aurelius84 Aurelius84 Awaiting requested review from Aurelius84

@gouzil gouzil Awaiting requested review from gouzil gouzil is a code owner

Assignees

@SigureMo SigureMo

Labels

contributor External developers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zrr1999 @SigureMo @XieYunshen