Skip to content

Conversation

@winter-wang
Copy link
Contributor

@winter-wang winter-wang commented May 9, 2024

PR Category

Auto Parallel

PR Types

Not User Facing

Description

add dp precision verify unit test.

Other

Pcard-67164

@paddle-bot
Copy link

paddle-bot bot commented May 9, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

)
for envs in envs_list:
# self._log_dir.name = "./log"
self._log_dir.name = "./log"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remember to remove this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, thanks!

allgather_value = paddle._pir_ops.c_allgather(
src_value, group.id, num_of_process, False
)
allgather_value.set_type(dst_type)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should think about a better method to remove this hack, like communication operation in pir using special infermeta_local

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed, I will systematically solve this problem in the next pr.

@winter-wang winter-wang force-pushed the cf_develop branch 6 times, most recently from 0e9e9b4 to feddb28 Compare May 10, 2024 07:54
Copy link
Contributor

@sunzhongkai588 sunzhongkai588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@winter-wang winter-wang merged commit 2a436d7 into PaddlePaddle:develop May 11, 2024
co63oc pushed a commit to co63oc/Paddle that referenced this pull request May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants