Skip to content

Conversation

@LLee233
Copy link
Contributor

@LLee233 LLee233 commented May 6, 2024

PR Category

Others

PR Types

New features

Description

Based on new pass mechanism, here we add pass "shuffle_channel_detect_pass" for PIR.

The new pass is same as "shuffle_channel_onednn_detect_pass" in "/paddle/fluid/framework/ir/onednn/shuffle_channel_onednn_detect_pass.cc".

Note: add shuffle_channel/shuffle_channel_grad in ops.yaml/ops_backward.yaml to adapt PIR op.

@paddle-bot
Copy link

paddle-bot bot commented May 6, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label May 6, 2024
@LLee233 LLee233 added the Intel label May 6, 2024
@LLee233 LLee233 force-pushed the shuffle_channel_pass branch 5 times, most recently from 2c71d38 to eb7383d Compare May 9, 2024 01:58
@LLee233
Copy link
Contributor Author

LLee233 commented May 10, 2024

@onecatcn Hi, would you mind helping find approvers as below? Since this PR includes OP API changes:
image

Thank you!

@onecatcn
Copy link
Contributor

2024-05-10 13:32:59 **************************************************************
2024-05-10 13:32:59 Please find RD for approval first, and then find TPM for approval.
2024-05-10 13:32:59 0. You must have one RD (XiaoguangHu01, jeff41404, lanxianghit or qingqing01) approval for API change.
2024-05-10 13:32:59 and one TPM approval for API change:
2024-05-10 13:32:59 jzhang533/ZhangJun, sunzhongkai588/SunZhongKai, Ligoml/LiMengLiu for general APIs.
2024-05-10 13:32:59 1. You must have one RD (XiaoguangHu01, jeff41404, lanxianghit or qingqing01) approval for API change.
2024-05-10 13:32:59 and one TPM approval for API change:
2024-05-10 13:32:59 jzhang533/ZhangJun, sunzhongkai588/SunZhongKai, Ligoml/LiMengLiu for general APIs.
2024-05-10 13:32:59 2. You must have one TPM approval for API documents change:
2024-05-10 13:32:59 jzhang533/ZhangJun, sunzhongkai588/SunZhongKai, Ligoml/LiMengLiu for general API docs.
2024-05-10 13:32:59
2024-05-10 13:32:59 There are 3 approved errors.
2024-05-10 13:32:59 **************************************************************

@onecatcn onecatcn requested a review from qingqing01 May 10, 2024 07:52
@onecatcn onecatcn assigned jzhang533 and unassigned jzhang533 May 10, 2024
@onecatcn onecatcn requested a review from jzhang533 May 10, 2024 07:53
@LLee233 LLee233 requested a review from XiaoguangHu01 May 10, 2024 08:32
Copy link
Contributor

@jzhang533 jzhang533 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for api changes

@onecatcn onecatcn removed the request for review from XiaoguangHu01 May 11, 2024 08:58
@xinyu-intel xinyu-intel merged commit 8a612f3 into PaddlePaddle:develop May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor External developers Intel

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants