-
Notifications
You must be signed in to change notification settings - Fork 5.9k
[pybind11] Fixed compiling errors for pybind11 -Wmissing-field-initializers under gcc8 and python312
#63949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
gouzil
merged 4 commits into
PaddlePaddle:develop
from
gouzil:fix_pybind11_v2_12_0_arm_gcc8
Apr 29, 2024
Merged
[pybind11] Fixed compiling errors for pybind11 -Wmissing-field-initializers under gcc8 and python312
#63949
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| diff --git a/include/pybind11/detail/internals.h b/include/pybind11/detail/internals.h | ||
| index c1047e4a..e09a6495 100644 | ||
| --- a/include/pybind11/detail/internals.h | ||
| +++ b/include/pybind11/detail/internals.h | ||
| @@ -193,11 +193,18 @@ struct internals { | ||
| PyTypeObject *default_metaclass; | ||
| PyObject *instance_base; | ||
| #if defined(WITH_THREAD) | ||
| +#if defined(__GNUC__) && !defined(__clang__) && __GNUC__ <= 8 | ||
| +#pragma GCC diagnostic push | ||
| +#pragma GCC diagnostic ignored "-Wmissing-field-initializers" | ||
| +#endif | ||
| // Unused if PYBIND11_SIMPLE_GIL_MANAGEMENT is defined: | ||
| PYBIND11_TLS_KEY_INIT(tstate) | ||
| # if PYBIND11_INTERNALS_VERSION > 4 | ||
| PYBIND11_TLS_KEY_INIT(loader_life_support_tls_key) | ||
| # endif // PYBIND11_INTERNALS_VERSION > 4 | ||
| +#if defined(__GNUC__) && !defined(__clang__) && __GNUC__ <= 8 | ||
| +#pragma GCC diagnostic pop | ||
| +#endif | ||
| // Unused if PYBIND11_SIMPLE_GIL_MANAGEMENT is defined: | ||
| PyInterpreterState *istate = nullptr; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
加个注释吧,说明这个 patch 可以在 gcc 9.1+ 安全移除
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done