Skip to content

Conversation

@changeyoung98
Copy link
Contributor

@changeyoung98 changeyoung98 commented Apr 17, 2024

PR Category

Others

PR Types

Others

Description

pcard-67164
Refine dirs and migrate apis

  • 整理C++function头文件,将save_load_parameters.h整合进interface.h
  • 整理paddle/static/io.py,将新增的pir函数分支独立出去放在paddle/static/pir_io.py中,在原函数的pir分支下调用;将二者共用的辅助函数放在paddle/static/io_utils.py中。
  • static下对外暴露的原接口与pir接口对应关系:
    • save->save_pir, load->load_pir
    • save_vars->save_vars_pir, load_vars->load_vars_pir,
    • save_inference_model->save_inference_model_pir, load_inference_model->load_inference_model_pir

@paddle-bot
Copy link

paddle-bot bot commented Apr 17, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

return params, opts


def set_var(name, ndarray):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个不是公共函数?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不是的,之前是个闭包函数,我给移出来了

Copy link
Contributor

@xiaoguoguo626807 xiaoguoguo626807 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

增加一下描述,介绍pr迁移的各函数功能和调用关系,以及与原接口的对应关系,这些接口不对外暴露,使用_xxx命名

Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@changeyoung98 changeyoung98 merged commit bdd87fa into PaddlePaddle:develop Apr 18, 2024
@changeyoung98 changeyoung98 deleted the czy-saveload branch April 28, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants