-
Notifications
You must be signed in to change notification settings - Fork 5.9k
[PIR save/load]Refine dirs and migrate apis #63622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PIR save/load]Refine dirs and migrate apis #63622
Conversation
|
你的PR提交成功,感谢你对开源项目的贡献! |
| return params, opts | ||
|
|
||
|
|
||
| def set_var(name, ndarray): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个不是公共函数?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不是的,之前是个闭包函数,我给移出来了
xiaoguoguo626807
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
增加一下描述,介绍pr迁移的各函数功能和调用关系,以及与原接口的对应关系,这些接口不对外暴露,使用_xxx命名
wanghuancoder
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
XiaoguangHu01
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR Category
Others
PR Types
Others
Description
pcard-67164
Refine dirs and migrate apis
paddle/static/io.py,将新增的pir函数分支独立出去放在paddle/static/pir_io.py中,在原函数的pir分支下调用;将二者共用的辅助函数放在paddle/static/io_utils.py中。save->save_pir,load->load_pirsave_vars->save_vars_pir,load_vars->load_vars_pir,save_inference_model->save_inference_model_pir,load_inference_model->load_inference_model_pir