-
Notifications
You must be signed in to change notification settings - Fork 5.9k
add illustration for reshape API #63365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…the indefinite article
… my-branch add illustration for the reshape API && fix grammatical mistakes of the indefinite article
|
你的PR提交成功,感谢你对开源项目的贡献! |
python/paddle/tensor/manipulation.py
Outdated
| The following figure illustrates the first example -- a 3D tensor of shape [2, 4, 6] is transformed into a 2D tensor of shape [6, 8], during which the order and values of the elements in the tensor remain unchanged. The elements in the two subdiagrams correspond to each other, clearly demonstrating how the reshape API works. | ||
|  |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这边不要用 markdown 格式的图片引用,否则无法渲染,可以看预览。和中文( PaddlePaddle/docs#6569 )一致即可,但引用路径需要改一下,因为仓库换了(docs -> Paddle)。
因为英文文档是通过抽取源码里的docstring,生产.rst 文件,所以和中文一样,得符合 sphinx 语法。
python/paddle/tensor/manipulation.py
Outdated
| Args: | ||
| x (Tensor): An N-D Tensor. The data type is ``float16``, ``float32``, ``float64``, ``int16``, ``int32``, ``int64``, ``int8``, ``uint8``, ``complex64``, ``complex128``, ``bfloat16`` or ``bool``. | ||
| x (Tensor): A N-D Tensor. The data type is ``float16``, ``float32``, ``float64``, ``int16``, ``int32``, ``int64``, ``int8``, ``uint8``, ``complex64``, ``complex128``, ``bfloat16`` or ``bool``. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
很细心,但 N-D Tensor 的发音以元音音素开始(即 N "en" 的发音),因此前面应该使用 an,1-D Tensor也同理("one"的发音开始)
不过 Tensor 前面确实是跟着 a
… my-branch add illustration for reshape API
sunzhongkai588
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* feat:add illustration for reshape API && fix:grammatical mistakes of the indefinite article * bug fixes * add illustration for reshape API * Update python/paddle/tensor/manipulation.py * add illustration for reshape API * Update python/paddle/tensor/manipulation.py --------- Co-authored-by: zachary sun <[email protected]>
* feat:add illustration for reshape API && fix:grammatical mistakes of the indefinite article * bug fixes * add illustration for reshape API * Update python/paddle/tensor/manipulation.py * add illustration for reshape API * Update python/paddle/tensor/manipulation.py --------- Co-authored-by: zachary sun <[email protected]>
PR Category
User Experience
PR Types
Docs
Description
对应的中文文档修复为:PaddlePaddle/docs#6569