Skip to content

Conversation

@HydrogenSulfate
Copy link
Contributor

@HydrogenSulfate HydrogenSulfate commented Apr 1, 2024

PR Category

Operator Mechanism

PR Types

New features

Description

Pcard-75624

Add p_norm_decomp as composite forwad API for p_norm

  • Add unitest

@paddle-bot
Copy link

paddle-bot bot commented Apr 1, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot
Copy link

paddle-bot bot commented Apr 1, 2024

❌ The PR is not created using PR's template. You can refer to this Demo.
Please use PR's template, it helps save our maintainers' time so that more developers get helped.

@HydrogenSulfate HydrogenSulfate changed the title [Prim] Add p_norm_decomp [Prim][WIP] Add p_norm_decomp Apr 1, 2024
return res;
}
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议组合算子签名和PHI/PIR签名保持一致,用namespace约束分类,函数名不要加_decomp。存量的可以后续统一修改

@HydrogenSulfate HydrogenSulfate changed the title [Prim][WIP] Add p_norm_decomp [Prim] Add p_norm_decomp Apr 7, 2024
Copy link
Contributor

@Xreki Xreki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the atol

@HydrogenSulfate HydrogenSulfate merged commit f02f1fe into PaddlePaddle:develop Apr 7, 2024
@HydrogenSulfate HydrogenSulfate deleted the add_p_norm_decomp branch April 7, 2024 08:02
co63oc pushed a commit to co63oc/Paddle that referenced this pull request Apr 9, 2024
* add p_norm_decomp

* use rsqrt

* support for porder is float

* update UT

* update UT

* update atol and rtol

* support 0, 1, inf, -inf norm

* update UT for 0, 1, inf, -inf norm

* remove 0-norm for it has benn replaced with paddle.count_nonzero in linalg
co63oc pushed a commit to co63oc/Paddle that referenced this pull request Apr 10, 2024
* add p_norm_decomp

* use rsqrt

* support for porder is float

* update UT

* update UT

* update atol and rtol

* support 0, 1, inf, -inf norm

* update UT for 0, 1, inf, -inf norm

* remove 0-norm for it has benn replaced with paddle.count_nonzero in linalg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants