[Inference]Pir support input/output hook #63101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
❌ The PR is not created using PR's template. You can refer to this Demo. |
yuanlehome
reviewed
Mar 29, 2024
Comment on lines
38
to
39
| using PirHookFunc = | ||
| std::function<void(InstructionBase*, ValueExecutionInfo*, Scope*)>; |
Contributor
There was a problem hiding this comment.
这个和上面的IfInstruction里的不需要重复写这个using，paddle/fluid/framework/new_executor/new_executor_defs.h里写过之后，应该都是可以直接用的
yuanlehome
reviewed
Mar 29, 2024
Comment on lines
31
to
33
| using HookFunc = std::function<void(OperatorBase*, Scope*)>; | ||
| using PirHookFunc = | ||
| std::function<void(InstructionBase*, ValueExecutionInfo*, Scope*)>; |
Contributor
There was a problem hiding this comment.
这里尝试下能不能也删去，包含paddle/fluid/framework/new_executor/new_executor_defs.h头文件
yuanlehome
reviewed
Mar 29, 2024
| if (op.isa<paddle::dialect::IfOp>()) { // NOLINT | ||
| vec_instruction_base_.emplace_back(std::make_unique<IfInstruction>( | ||
| op_idx++, place_, &op, value_exe_info_.get(), execution_config_)); | ||
| std::unique_ptr<IfInstruction> ifInstrPtr = |
Contributor
There was a problem hiding this comment.
变量的命名我们一般都是小写+下划线，其他地方一并改下
yuanlehome
reviewed
Mar 29, 2024
Comment on lines
104
to
111
| void SetOutputHooks(const std::vector<PirHookFunc>& hookfuncs) override { | ||
| pir_output_hookfuncs_ = hookfuncs; | ||
| } | ||
|
|
||
| void SetInputHooks(const std::vector<PirHookFunc>& hookfuncs) override { | ||
| pir_input_hookfuncs_ = hookfuncs; | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
这个文件的修改是完全不需要的哈，这是旧IR相关的
yuanlehome
reviewed
Mar 29, 2024
Comment on lines
250
to
252
| std::vector<PirHookFunc> pir_output_hookfuncs_; | ||
| std::vector<PirHookFunc> pir_input_hookfuncs_; | ||
|
|
zhangbo9674
approved these changes
Mar 29, 2024
qingqing01
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Inference
PR Types
New features
Description
Python示例：
predictor会在每个op调用时打印op的input信息和output信息
输出结果示例（op name:op id 、tensor name 、tensor value）：