Skip to content

Conversation

@SigureMo
Copy link
Member

PR types

Bug fixes

PR changes

Others

Description

修复 Trans2ContiguousTensors 后 name 缺失导致 share 到 scope 里的 Variable 名字为空,进而导致后续执行阶段找不到 Variable 而挂掉的问题

PCard-66972

@paddle-bot
Copy link

paddle-bot bot commented Mar 20, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@SigureMo SigureMo requested a review from gouzil March 20, 2024 13:06
const std::string &name)
: impl_(std::move(tensor_impl)),
autograd_meta_(std::move(autograd_meta)),
name_(name) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zyfncg review 这里,这个构造函数是在 #57352 引入的,仅用于 trans2contiguous,这个 API 是否可以修改?如果不可以修改是新增一个更合适嘛?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以直接改这个API,新增接口的代价会更高一些

Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

const std::string &name)
: impl_(std::move(tensor_impl)),
autograd_meta_(std::move(autograd_meta)),
name_(name) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以直接改这个API,新增接口的代价会更高一些

@SigureMo SigureMo merged commit 8e7f5e6 into PaddlePaddle:develop Mar 22, 2024
@SigureMo SigureMo deleted the dy2st/fix-trans-to-contiguous-missing-name branch March 22, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants