[PIR] support normal and fix TestNoBackwardAPIStatic.test_normal UT
#62864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
SigureMo
reviewed
Mar 19, 2024
| "If std is Tensor, it's data type only support float32, float64.", | ||
| ) | ||
| if shape is not None: | ||
| check_shape(shape, 'normal') |
Member
There was a problem hiding this comment.
744 行改回 if not in_dynamic_mode(): 可以么？这样 PIR 下少了很多检查，当然 Variable 相关位置需要加一下 Value
SigureMo
reviewed
Mar 19, 2024
| self.std, np.ndarray | ||
| ): | ||
| with paddle.static.program_guard(paddle.static.Program()): | ||
| with paddle.static.program_guard(main_program): |
Member
Author
There was a problem hiding this comment.
我记得这玩意之前有点问题来着，不会切换还是啥的
|
|
||
|
|
||
| class TestNormalErrors(unittest.TestCase): | ||
| def test_errors(self): |
gouzil
changed the title
TestNoBackwardAPIStatic.test_normal UTTestNoBackwardAPIStatic.test_normal UT
XieYunshen
previously approved these changes
Mar 20, 2024
Member
|
Coverage 已过，可以 rename 回原来的名字了～ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Description
适配
paddle.normalAPI, 并打开TestNoBackwardAPIStatic.test_normal单测相关链接:
test_zero_dim_*.py- step: 2 #62652