Skip to content

Replace LOG(FATAL) PADDLE_THROW in paddle/cinn #62744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
luotao1 merged 11 commits into from
Mar 19, 2024
Merged

Replace LOG(FATAL) PADDLE_THROW in paddle/cinn #62744

luotao1 merged 11 commits into from
Mar 19, 2024

Conversation

@co63oc
Copy link
Contributor

@co63oc co63oc commented Mar 15, 2024 •
edited
Loading

PR types

Others

PR changes

Others

Description

https://github.com/PaddlePaddle/Paddle/wiki/Paddle-Error-Message-Writing-Specification
image

LOG(FATAL)替换为PADDLE_THROW，目录 paddle/cinn

@paddle-bot
Copy link

paddle-bot bot commented Mar 15, 2024

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Mar 15, 2024
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Mar 15, 2024
@co63oc
Copy link
Contributor Author

co63oc commented Mar 16, 2024

@Galaxy1458 @risemeup1 CI已完成，麻烦有时间review下

Galaxy1458
Galaxy1458 reviewed Mar 18, 2024
View reviewed changes
Copy link
Contributor

@Galaxy1458 Galaxy1458 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

还是希望替换为PADDLE_THROW, CINN_THROW会逐步废弃。

@co63oc
Copy link
Contributor Author

co63oc commented Mar 18, 2024

还是希望替换为PADDLE_THROW, CINN_THROW会逐步废弃。

好的那我试下

@Galaxy1458 Galaxy1458 closed this Mar 18, 2024
@Galaxy1458 Galaxy1458 reopened this Mar 18, 2024
@co63oc co63oc changed the title Replace LOG(FATAL) CINN_THROW in paddle/cinn Replace LOG(FATAL) PADDLE_THROW in paddle/cinn Mar 18, 2024
@co63oc
Copy link
Contributor Author

co63oc commented Mar 18, 2024

@Galaxy1458 CI已完成麻烦有时间review下

Galaxy1458
Galaxy1458 reviewed Mar 19, 2024
View reviewed changes
Copy link
Contributor

@Galaxy1458 Galaxy1458 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job!

@co63oc
Copy link
Contributor Author

co63oc commented Mar 19, 2024

@luotao1 CI已完成

@luotao1 luotao1 merged commit 7e33dd7 into PaddlePaddle:develop Mar 19, 2024
Galaxy1458
Galaxy1458 reviewed Mar 19, 2024
View reviewed changes
Copy link
Contributor

@Galaxy1458 Galaxy1458 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

目前LOG(FATAL)还存在仅11个文件，是否有兴趣下一步计划？
5376fed0ab22c31265113c146ab20f70

@co63oc
Copy link
Contributor Author

co63oc commented Mar 19, 2024

目前LOG(FATAL)还存在仅11个文件，是否有兴趣下一步计划？ 5376fed0ab22c31265113c146ab20f70

@Galaxy1458 好的再修改，LOG(WARNING), LOG(INFO)是否要替换，如果替换是替换为什么

@Galaxy1458
Copy link
Contributor

Galaxy1458 commented Mar 19, 2024

LOG(WARNING), LOG(INFO)
好的，，LOG(WARNING), LOG(INFO)不需要替换。

@co63oc co63oc deleted the fix20 branch March 19, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Galaxy1458 Galaxy1458 Galaxy1458 approved these changes

Assignees

@luotao1 luotao1

@Galaxy1458 Galaxy1458

@risemeup1 risemeup1

Labels

contributor External developers HappyOpenSource 快乐开源活动issue与PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@co63oc @Galaxy1458 @luotao1 @risemeup1