Skip to content

Conversation

@LLee233
Copy link
Contributor

@LLee233 LLee233 commented Mar 14, 2024

PR types

New features

PR changes

Others

Description

Based on new pass mechanism, here we add pass "matmul_elementwise_add_fuse_pass" for PIR.

The new pass is same as "matmul_elementwise_add_mkldnn_fuse_pass" in "/paddle/fluid/framework/ir/mkldnn/matmul_elementwise_add_mkldnn_fuse_pass.cc"

@paddle-bot
Copy link

paddle-bot bot commented Mar 14, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Mar 14, 2024
@LLee233 LLee233 changed the title [oneDNN] Add matmul_elementwise_add_fuse_pass [oneDNN][PIR] Add matmul_elementwise_add_fuse_pass Mar 14, 2024
@LLee233 LLee233 changed the title [oneDNN][PIR] Add matmul_elementwise_add_fuse_pass [PIR][oneDNN] Add matmul_elementwise_add_fuse_pass Mar 14, 2024
@LLee233
Copy link
Contributor Author

LLee233 commented Mar 15, 2024

Hi @yuanlehome! Could you help review this PR? It already passed CI. Thanks~

@yuanlehome
Copy link
Contributor

Hi @yuanlehome! Could you help review this PR? It already passed CI. Thanks~

可否merge下develop,重跑下ci,昨天发现了个bug,ci一直没有跑到onednn的pass ut,修复 #62734 今早合入的,另外也建议在单测文件的每个case前加下图结构注释,类似
image

@LLee233
Copy link
Contributor Author

LLee233 commented Mar 15, 2024

Hi @yuanlehome! Could you help review this PR? It already passed CI. Thanks~

可否merge下develop,重跑下ci,昨天发现了个bug,ci一直没有跑到onednn的pass ut,修复 #62734 今早合入的,另外也建议在单测文件的每个case前加下图结构注释,类似 image

好的,我一会儿update一下

@LLee233 LLee233 force-pushed the matmul_eltwiseadd_pass branch from 4492bde to 2e507f2 Compare March 15, 2024 15:12
@LLee233
Copy link
Contributor Author

LLee233 commented Mar 18, 2024

Hi @yuanlehome,我这边rebase了develop,test case加了图注释然后CI也过了,可以麻烦再review一下吗?Thx~

yuanlehome
yuanlehome previously approved these changes Mar 18, 2024
Copy link
Contributor

@yuanlehome yuanlehome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LLee233
Copy link
Contributor Author

LLee233 commented Mar 18, 2024

Hi @wanghuancoder,可以麻烦请你也帮忙review看看还有哪里需要改动的吗?Thx~

Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xinyu-intel xinyu-intel merged commit abfe394 into PaddlePaddle:develop Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor External developers Intel

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants