-
Notifications
You must be signed in to change notification settings - Fork 5.9k
[PIR][Dy2St] Adapt opcallstack for D2S #62536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PIR][Dy2St] Adapt opcallstack for D2S #62536
Conversation
|
你的PR提交成功,感谢你对开源项目的贡献! |
|
|
||
| [tool.ruff.lint.per-file-ignores] | ||
| # These files need tabs for testing. | ||
| "test/dygraph_to_static/test_legacy_error.py" = ["E101", "W191"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我试了一下 ruff 似乎两个都不需要 ignore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
那可能是 ruff 和 flake8 实现不一致了
| op.callstack = get_new_op_callstack(op.callstack) | ||
| else: | ||
| for block in program.blocks: | ||
| for i, op in enumerate(block.ops): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| for i, op in enumerate(block.ops): | |
| for op in block.ops: |
可以不需要使用enumerate吧
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
老代码加缩进而已,反正这个分支以后也会删
SigureMo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wanghuancoder
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR types
Others
PR changes
Others
Description
动转静下适配op_callstack