Skip to content

Conversation

@xingmingyyj
Copy link
Contributor

PR types

Others

PR changes

Others

Description

动转静下适配op_callstack

@paddle-bot
Copy link

paddle-bot bot commented Mar 7, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Mar 7, 2024
@SigureMo SigureMo self-assigned this Mar 8, 2024
@SigureMo SigureMo changed the title [PIR] Adapt opcallstack for D2S [PIR][Dy2St] Adapt opcallstack for D2S Mar 8, 2024
@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Mar 9, 2024
@PaddlePaddle PaddlePaddle unlocked this conversation Mar 9, 2024
@SigureMo SigureMo closed this Mar 9, 2024
@SigureMo SigureMo reopened this Mar 9, 2024
@SigureMo SigureMo requested a review from gouzil March 11, 2024 09:10

[tool.ruff.lint.per-file-ignores]
# These files need tabs for testing.
"test/dygraph_to_static/test_legacy_error.py" = ["E101", "W191"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我试了一下 ruff 似乎两个都不需要 ignore

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

那可能是 ruff 和 flake8 实现不一致了

op.callstack = get_new_op_callstack(op.callstack)
else:
for block in program.blocks:
for i, op in enumerate(block.ops):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
for i, op in enumerate(block.ops):
for op in block.ops:

可以不需要使用enumerate

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

老代码加缩进而已,反正这个分支以后也会删

gouzil
gouzil previously approved these changes Mar 11, 2024
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SigureMo SigureMo merged commit b2e563e into PaddlePaddle:develop Mar 12, 2024
@xingmingyyj xingmingyyj deleted the adaptive_opcallstack branch March 12, 2024 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor External developers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants