bugfix, add skipIf for multigpu tests #62499
Conversation
|
你的PR提交成功，感谢你对开源项目的贡献! |
| if num_of_devices > paddle.device.cuda.device_count(): | ||
| self.skipTest("number of GPUs is not enough") |
There was a problem hiding this comment.
I don't think need this if-condition here because all the test-case inherited this base class only use 2-cards. And CI machines which run these test-cases only has two devices either.
There was a problem hiding this comment.
@LiYuRio ,
Thanks for the response.
CI machines which run these test-cases only has two devices either.
Inside Baidu, it is true but for other developers, it might not be true. This line can give other developers a simple, more meaningful reason to show why unit tests cannot run, instead of a long bug message. Does it make sense?
There was a problem hiding this comment.
ok, but if we add skipTest here, is it necessary to add skipTest to all distributed test case? Not only in communication test case.
There was a problem hiding this comment.
@LiYuRio ,
Yes, it will be best. I just found another test (test/legacy_test/op_test.py) has the same issue. This is all I have found for now.
|
Sorry to inform you that 7a964fe's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
jeng1220
force-pushed
the
bugfix_multigpu_unittest
branch
2 times, most recently
from
8036dcb to
b2d0ac2
Compare
|
Sorry to inform you that b2d0ac2's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
jeng1220
force-pushed
the
bugfix_multigpu_unittest
branch
from
b2d0ac2 to
2378025
Compare
3 participants
PR Category
Others
PR Types
Bug fixes
Description
Not all CI/CD machines have 8 GPUs, so this PR adds
skipifif number of GPUs is not enough