Skip to content

[PIR] Filter out attribute op_callstack when print program #62469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SigureMo merged 2 commits into from
Mar 6, 2024
Merged

[PIR] Filter out attribute op_callstack when print program #62469

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f57a91b
[PIR] Filter out attribute `op_callstack` when print program
SigureMo Mar 6, 2024
2d0a1f0
dont include fluid
SigureMo Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions paddle/pir/src/core/ir_printer.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
#include <string>
#include <unordered_map>

#include "paddle/fluid/framework/op_proto_maker.h"
Copy link
Contributor

@kangguangli kangguangli Mar 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

依赖fluid目录下的文件感觉不太好，要不就在这个文件里新定义个常量吧

Copy link
Member Author

@SigureMo SigureMo Mar 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改～

#include "paddle/pir/include/core/block.h"
#include "paddle/pir/include/core/builtin_attribute.h"
#include "paddle/pir/include/core/builtin_type.h"
Expand Down Expand Up @@ -279,6 +280,11 @@ void IrPrinter::PrintAttributeMap(Operation* op) {
AttributeMap attributes = op->attributes();
std::map<std::string, Attribute, std::less<>> order_attributes(
attributes.begin(), attributes.end());

// Filter out the callstack attribute
order_attributes.erase(
paddle::framework::OpProtoAndCheckerMaker::OpCreationCallstackAttrName());

os << " {";

pir::detail::PrintInterleave(
Expand Down