Skip to content

prohibit the use of IR_ENFORCE #62445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
risemeup1 merged 9 commits into from
Mar 7, 2024
Merged

prohibit the use of IR_ENFORCE #62445

Changes from 6 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
da0fdfb
fix,test=document_fix
risemeup1 Mar 6, 2024
4616f3c
fix,test=document_fix
risemeup1 Mar 6, 2024
ac4d241
fix,test=document_fix
risemeup1 Mar 6, 2024
bd18bbc
fix,test=document_fix
risemeup1 Mar 6, 2024
705d1f6
fix
risemeup1 Mar 6, 2024
9253a7e
fix,test=document_fix
risemeup1 Mar 6, 2024
3ebfd44
fix,test=document_fix
risemeup1 Mar 6, 2024
7f5ff86
fix,test=document_fix
risemeup1 Mar 6, 2024
13ceac7
fix,test=document_fix
risemeup1 Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions tools/check_file_diff_approvals.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,12 +343,14 @@ if [ "${HAS_MODIFIED_FRAMEWORK_EXECUTOR}" != "" ] && [ "${GIT_PR_ID}" != "" ]; t
check_approval 1 From00 zhangbo9674
fi


HAS_MODIFIED_DRR_INCLUDE_DIR=`git diff --name-only upstream/$BRANCH | grep "paddle/fluid/pir/drr/include" || true`
if [ "${HAS_MODIFIED_DRR_INCLUDE_DIR}" != "" ] && [ "${GIT_PR_ID}" != "" ]; then
echo_line="You must have one RD (yuanlehome, zyfncg) approval for file changes in paddle/fluid/pir/drr/include.\n"
check_approval 1 yuanlehome zyfncg
fi


HAS_MODIFIED_PIR_INCLUDE_DIR=`git diff --name-only upstream/$BRANCH | grep "paddle/pir/include" || true`
if [ "${HAS_MODIFIED_PIR_INCLUDE_DIR}" != "" ] && [ "${GIT_PR_ID}" != "" ]; then
echo_line="You must have one RD (yuanlehome, winter-wang, zhangbo9674) approval for file changes in paddle/pir/include.\n"
Expand Down Expand Up @@ -391,6 +393,14 @@ if [ "${HAS_MODIFIED_STATIC_BUILD}" != "" ] && [ "${GIT_PR_ID}" != ""]; then
check_approval 1 From00 zhiqiu
fi


HAS_MODIFIED_ENFORCE_SYNTAX=`git diff upstream/$BRANCH | grep -E "IR_ENFORCE|CHECK_EQ|CHECK_NE|CHECK_LT|CHECK_LE|CHECK_GE|CHECK_GT|LOG\(FATAL\)" || true`
if [ "${HAS_MODIFIED_ENFORCE_SYNTAX}" != "" ] && [ "${GIT_PR_ID}" != "" ]; then
echo_line="You must have one RD (rismeup1 or winter-wang) approval for using 'IR_ENFORCE, COMMON_ENFORCE, CHECK_EQ, CHECK_NE, CHECK_LT, CHECK_LE, CHECK_GE, CHECK_GT, LOG(FATAL)', it is recommended to use paddle_ENFORCE as a replacement.\n"
check_approval 1 risemeup1 winter-wang
fi


HAS_MODIFIED_TARGET_FOR_AUTO_PARALLEL_CI=`git diff --name-only upstream/$BRANCH | grep "tools/auto_parallel/target_path_lists.sh" || true`
if [ "${HAS_MODIFIED_TARGET_FOR_AUTO_PARALLEL_CI}" != "" ] && [ "${GIT_PR_ID}" != "" ]; then
echo_line="You must have one RD (zhiqiu(Recommend) or chenwhql) approval for file changes in tools/auto_parallel/target_path_lists.sh.\n"
Expand Down