Skip to content

[CINN] Refact struct group #62339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tc20042008 merged 1 commit into from
Mar 25, 2024
Merged

[CINN] Refact struct group #62339

tc20042008 merged 1 commit into from
Mar 25, 2024

Conversation

@ZelinMa557
Copy link
Contributor

@ZelinMa557 ZelinMa557 commented Mar 3, 2024 •
edited
Loading

PR types

Others

PR changes

Others

Description

Replace struct Group with OpLoweringGroup in the lower_cinn_fusion_op_pass.

@paddle-bot
Copy link

paddle-bot bot commented Mar 3, 2024

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@CLAassistant
Copy link

CLAassistant commented Mar 3, 2024 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@CLAassistant
Copy link

CLAassistant commented Mar 3, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@paddle-bot paddle-bot bot added the contributor External developers label Mar 3, 2024
@paddle-bot
Copy link

paddle-bot bot commented Mar 3, 2024

❌ The PR is not created using PR's template. You can refer to this Demo.
Please use PR's template, it helps save our maintainers' time so that more developers get helped.

@ZelinMa557 ZelinMa557 marked this pull request as draft March 3, 2024 13:03
@ZelinMa557 ZelinMa557 marked this pull request as ready for review March 4, 2024 06:30
zyfncg
zyfncg reviewed Mar 4, 2024
View reviewed changes
paddle/cinn/hlir/framework/op_lowering.h Outdated
auto* impl_base = new pir::OpLowererImpl(target);
return OpLowerer<pir::GroupPtr>(impl_base);
}

Copy link
Contributor

@zyfncg zyfncg Mar 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

原先的pir::GroupPtr接口需要删掉

paddle/cinn/hlir/framework/pir/group.h Outdated
Comment on lines 287 to 288
using GroupPtr = std::shared_ptr<Group>;
GroupPtr base_group;
Copy link
Contributor

@zyfncg zyfncg Mar 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不需要持有原来的Group，需要的成员直接拷贝过来，这个class可以单独放到一个新文件中

Copy link
Contributor Author

@ZelinMa557 ZelinMa557 Mar 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, 我再修改一下

@ZelinMa557 ZelinMa557 force-pushed the refact-group branch 8 times, most recently from 5f663f5 to 8f2a4f3 Compare March 8, 2024 06:04
@ZelinMa557 ZelinMa557 mentioned this pull request Mar 8, 2024
Closed
28 tasks
tc20042008
tc20042008 reviewed Mar 8, 2024
View reviewed changes
BiynXu
BiynXu reviewed Mar 8, 2024
View reviewed changes
@ZelinMa557 ZelinMa557 force-pushed the refact-group branch 8 times, most recently from 6fa8c68 to 1dccb6f Compare March 17, 2024 14:06
@ZelinMa557 ZelinMa557 requested review from tc20042008 and zyfncg March 18, 2024 03:13
@ZelinMa557 ZelinMa557 requested a review from BiynXu March 18, 2024 03:13
zyfncg
zyfncg previously approved these changes Mar 19, 2024
View reviewed changes
@ZelinMa557 ZelinMa557 force-pushed the refact-group branch 2 times, most recently from 46d0fac to bf1f14f Compare March 21, 2024 06:16
@Aurelius84 Aurelius84 changed the title [CINN] refact struct group [CINN] Refact struct group Mar 25, 2024
@tc20042008 tc20042008 merged commit a7d5ea9 into PaddlePaddle:develop Mar 25, 2024
@ZelinMa557 ZelinMa557 deleted the refact-group branch April 9, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Aurelius84 Aurelius84 Aurelius84 approved these changes

@zyfncg zyfncg zyfncg approved these changes

@tc20042008 tc20042008 tc20042008 approved these changes

@BiynXu BiynXu Awaiting requested review from BiynXu

Assignees

No one assigned

Labels

contributor External developers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ZelinMa557 @CLAassistant @Aurelius84 @zyfncg @BiynXu @tc20042008