[DRR]Fix SegmentFault for BlockArgument while applying pass in Llama2 infer #62283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Aurelius84
commented
Mar 1, 2024
| // Tigger early stop while operand is BlockArgument with | ||
| // producer_op==nullptr. | ||
| if (drr_producer_op && ir_producer_op == nullptr) { | ||
| matched = false; |
Contributor
Author
There was a problem hiding this comment.
核心修复方式是这三行，其他都是代码refine
tc20042008
approved these changes
Mar 1, 2024
yuanlehome
approved these changes
Mar 1, 2024
zyfncg
approved these changes
Mar 1, 2024
co63oc
pushed a commit
to co63oc/Paddle
that referenced
this pull request
Mar 2, 2024
… infer (PaddlePaddle#62283) * [DRR]Fix SegmentFault for BlockArgument while applying pass in Llama2 infer * fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Description
Pcard-67164
段错误的原因是 是DRR Pattern 少了一个分支case的处理逻辑。
在Llama2里触发的位置是下图
